search

asaskevich / govalidator

[Go] Package of validators and sanitizers for strings, numerics, slices and structs
MIT License
6k stars 556 forks source link

fix: include major in go.mod module directive #449

Open nightah opened 2 years ago

nightah commented 2 years ago
Q A
Documentation yes
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

This change includes the major version in the module path. This will ensure appropriate semver tagging.

Closes #384.

marclop commented 2 years ago

@asaskevich any reason not to update the go.mod file to make it compatible with Go modules?

sergeyglazyrindev commented 2 years ago

Hello guys! I forked this package cause owner disappeared. Hope, he will be back, but it would be easier to merge these changes back if he is back Link to my repo: create issue there and we'll discuss it.

tboerger commented 2 years ago

It would be great to get this merged, currently renovate seems to be not able to update the dependency automatically because of the go.mod definition :(

phil9909 commented 2 months ago

@sergeyglazyrindev it looks like you have merge permission on this repo now.

Could you maybe have a look at this PR? Currently, the repo can't be used cleanly in go module based projects.

sergeyglazyrindev commented 2 months ago

I don't have write access here.