Scripts may benefit from general refactoring

asayler / COG-Web

Web Frontend for COG

GNU Affero General Public License v3.0

2 stars 3 forks source link

Scripts may benefit from general refactoring #28

Closed hexacyanide closed 8 years ago

hexacyanide commented 8 years ago

I've been working with the JavaScript files for a while, and thought they might benefit from some improvements. Here is a list:

functions are not namespaced and are all defined in the global scope
there are nested function declarations (is considered an anti-pattern due to hoisting)
debug information is always shown (a dedicated debug library would be beneficial)
naming conventions and whitespace use are inconsistent

If not too unnecessary, I would like to rework most of the scripts.

asayler commented 8 years ago

By all means, have at it. I'm not really a JS programmer, so I'm sure there is plenty of room for improvement. I know just enough JS to build stuff like this for the backend APIs that are more my forte.

asayler commented 8 years ago

Fixed via https://github.com/asayler/COG-Web/pull/29.