asayler / COG-Web

Web Frontend for COG
GNU Affero General Public License v3.0
2 stars 3 forks source link

Refactor and restructure scripts, add detailed logging #29

Closed hexacyanide closed 8 years ago

hexacyanide commented 8 years ago

As of April 13, I have rebased onto PR #30, and have also done the following:


This pull request addresses issue #28, and accomplishes the following:

In general, there are only few visual differences in this PR, and they mostly have to do with optimization. If a user is unauthenticated, attempting to access a restricted page will no longer flash its contents. The loading of assignment/test listings will not briefly display older tests before the entire listing has been received, and the login button has default text (so it is not sizeless during loading). For anything involving a long listing, the client will wait until they have been all received rather than making rapid changes to the document.

I've done some basic testing, but it has not been extensive, so feedback would be appreciated. Since debug output is now off by default, it can be enabled by running the following in your browser console:

localStorage.debug = 'web-cog:*'

The setting above is persistent unless unset, or if domain-related data is reset, and will enable debug output for all console messages on the web-cog namespace. It should look similar to the following:

image

asayler commented 8 years ago

I'll aim to test this out today or tomoor. Taylor is working on a few additions to the history-view of the web interface as well, so if I end up merging those first this may require some minor rebasing to accommodate her changes.

asayler commented 8 years ago

I merged this in. Seems to be working well. Thanks!

That said, I can't seem to get the debug output working in Chrome or Firefox (testing on Ubuntu 14.04). I've run localStorage.debug = 'web-cog:*' in the console and I can see the value set it the local storage display, but no console logging appears. Thoughts?

hexacyanide commented 8 years ago

Looks like I reversed the keywords above; it should actually be:

localStorage.debug = 'cog-web:*';
asayler commented 8 years ago

Ahh. Yep. That did it!

Feel free to add a note to that effect to the README. Or I can.

asayler commented 8 years ago

I updated the README with the debug info.

asayler commented 8 years ago

Also, I pushed this out into production. But in doing so, I also came across a (probably simple to fix) login bug: https://github.com/asayler/COG-Web/issues/31. I can take a look at it later this week, but feel free to submit a fix if you know what the issue is off the top of your head.