asb2m10 / dexed

DX7 FM multi plaform/multi format plugin
GNU General Public License v3.0
2.86k stars 245 forks source link

Sysex messages force pitch bend messages #135

Closed papwalker closed 6 years ago

papwalker commented 6 years ago

Using High Sierra. If there are any Yamaha USB keyboards or synths plugged in and active, Dexed 0.9.4 a sound short tone will sound after Key Off or will generate a continuous tone depending on which host is used. This happens when using any midi source including Dexed Keyboard. It affects hosts Reaper, AU Lab, Hosting AU using Yamaha KX25, moXF6, moXF and likely others. It does affect the Dexed stand alone application. Sometimes changing clock / synch settings on keyboard can help.

NO issues when Midi is restricted to M Audio or other Midi inputs when Yamaha is off or disabled or unpluged. Tested on 3 different machines. Several Yamaha boards. DID NOT occur with 0.9.3 version.

Issue Does NOT affect Garage Band 10.2.0 or 6.0.5 Issue Does NOT affect Live Professor.

It DOES affect the Dexed stand alone application. It DOES affect Reaper 5.78 It DOES affect AU Lab 2.3 It DOES affect Hosting AU 1.5.0

Work around - do not use Yamaha equipment. No other issues detected. Other than that - Great job, especially the EG Timing. Thanks and cheers. Peter Walker

asb2m10 commented 6 years ago

The Yamaha keyboard is probably sending a sysex that Dexed handles badly. It probably works in Garage Band because it filters the sysex messages.

Can you install https://www.snoize.com/MIDIMonitor/ and try to record the exact midi messages that your Yamaha keyboards sends ?

Then, send me the results (attach files from the issue) and from there I'll be able to fix the issue.

Thanks.

papwalker commented 6 years ago

There are only Note On and Note Off events in Midi Monitor. HOWEVER There are continuous Midi clock messages in the log. Setting the Yamaha devices to Clock Off or External Sync resolves the issue.

All Yamaha synths tested have Sync = Auto and Clock = On as default settings. This is a problem as most users would not have a clue about these and altering them just for Dexed is not right especially since the previous version did not require this. My guess is that anything outputting clock messages will cause issues with Mac Dexed 0.9.4

[EDIT] Further to this ... Windows 7 has the same issue with Dexed and any Yamaha Synths using USB and have the default clock and sync settings. Roland Synths have same issue on all platforms. Software midi clock ala Midiclock (midiclock.com) also causes the same issue.

Any Midi clock messages from any source will interfere with Dexed 0.9.4

asb2m10 commented 6 years ago

Thanks for the info, I know what is the issue. Will post a fix shortly.

papwalker commented 6 years ago

Excellent. Dexed is my all-time favorite plugin for over three years. Thanks a lot.

asb2m10 commented 6 years ago

Thanks!

I tough I knew what it was but I cannot reproduce it on my side. I think this is really related to #136... I'll keep you posted.

papwalker commented 6 years ago

Try downloading midiclock midiclock.com Windows 7 and probably others ... I Feed to output of midiclock to a dexed app instance via a virtual midi cable. Dexed go mental.

... or really anything that generates a MIDI clock / sync. My Yamaha keyboards KX25 / moXF generate clock / sync but many 'dumber' midi controllers do not.

nesdnuma commented 6 years ago

Hello, I am chiming in this thread as I initiated the issue #136. I didn't have time to send you the requested Reaper session before issue #136 was closed but I can still do it if you want. Using either MIDIberry or Max's sysexin object, I can't see any sysex message coming from my CME XKey keyboard when playing. But if I filter the poly aftertouch messages in Reaper using MIDI Polysher VSTi (http://www.eareckon.com/en/products/freebies.html), the problem disappears.

rndrmlch commented 6 years ago

changing poly aftertouch to channel aftertouch in the XKey software has done the job for the time being though it's not entirely satisfactory.

nesdnuma commented 6 years ago

I can't switch to channel aftertouch globally as I do switch live from synths using poly aftertouch and synths which don't. So I filter the messages on Dexed's track but there's obviously an issue with poly aftertouch messages.

rndrmlch commented 6 years ago

I see. sounds like a viable solution.

nesdnuma commented 6 years ago

I have also made a poly to channel aftertouch JSFX plug-in for Reaper.

asb2m10 commented 6 years ago

Please test this build to see if it fixes the problem :

https://github.com/asb2m10/dexed/releases/download/v0.9.4hf1/dexed-0.9.4-win.zip

It should indicate version 0.9.4hf1 on startup. If everything is fine, I'll make the Mac builds tomorrow.

Thanks.

papwalker commented 6 years ago

Hi Pascal. Yes that seems to have resolved this issue. I used the midiclock appllication to put clock messages onto the bus with no issues. I used a Yamaha KX25 also outputing clock messages onto the bus with no issues. I used an moXF6 synth to put clock messages onto the bus with no issues. I observed the presence of messages using midiox to be sure.

asb2m10 commented 6 years ago

Ok good. I'm closing this issue.

papwalker commented 6 years ago

So the mac is version is no longer supported?

asb2m10 commented 6 years ago

yes

papwalker commented 6 years ago

@asb2m10 That's a shame, I've only just switched to the Mac, but Dexed is still terrific plugin and I can work around the issues by turning the clock source off. I realize how hard it is supporting multiple platforms (especially for free) cheers.

asb2m10 commented 6 years ago

Off course it is supported... just give time to built it and test the built (btw the mac version is updated).

nesdnuma commented 6 years ago

Thanks for the update. I confirm it functions correctly in Windows now!

papwalker commented 6 years ago

@asb2m10 I just built it on the mac this morning, a few implied conversion warnings, but it built and works fine so far with the Yamaha equipment. Confirmed I can see the clock messages on MIDI Monitor. I'll do a little regression testing but do not expect in trouble.

rickyackel commented 6 years ago

KVR currently has only March Builds. Where can I download the new build without building it? Thanks.

asb2m10 commented 6 years ago

The KVR builds contains the right version. Just download it again an reinstall it. You should see you are running 0.9.4hf1

papwalker commented 6 years ago

@asb2m10 Pascal, he has a Mac. OSX. The Mac install on KVR and GitHub is still March. I just downloaded to be sure, The Windows install is hf1. Linux version = 404 error

asb2m10 commented 6 years ago

Please try again. And for the Linux version, I need to have access to the it in the comming days.

papwalker commented 6 years ago

@asb2m10 @rickyackel OK. That's fixed it.