search

asb2m10 / dexed

DX7 FM multi plaform/multi format plugin
GNU General Public License v3.0
2.79k stars 242 forks source link

Not differentiating between 'EDIT' and 'FUNCTION' sysex parameter changes #156

Open Sentinel77 opened 6 years ago

Sentinel77 commented 6 years ago

Hi,

Dexed is not differentiating between the 'EDIT' and 'FUNCTION' sysex parameter changes that it recieves from the DX7.

e.g. pressing FUNCTION 2 (poly/mono) on the DX7 will cause dexed to change its OP3 EG Rate 2 to zero. Similar errors occur when pressing other function buttons.

The sysex look similar except for the fourth byte. FUNCTION 2 = f0 43 10 08 40 00 f7 OP3 EG Rate2 = f0 43 10 00 40 00 f7

Dexed would need to look at the fourth byte of the sysex to differentiate that it is recieving an EDIT parameter, and not a FUNCTION parameter.

DX7 EDIT parameters 1-15, 30-32 have 01 as the fourth sysex value DX7 EDIT parameters 16-29 have 00 as the fourth sysex value DX7 function parameters 2-7, 17-32 have 08 as the fourth sysex value

btw, a handy app for viewing the incoming sysex on linux is 'KMidimon'

asb2m10 commented 6 years ago

Thanks for reporting. I will fix this as soon as I can test it on my DX7.