Incomplete algorithms in Modern/OPL modes

asb2m10 / dexed

DX7 FM multi plaform/multi format plugin

GNU General Public License v3.0

2.83k stars 243 forks source link

Incomplete algorithms in Modern/OPL modes #242

Open mkruselj opened 4 years ago

mkruselj commented 4 years ago

https://github.com/asb2m10/dexed/blob/master/Source/msfa/fm_core.cc#L113

Algorithm 6 sounds exactly like algorithm 5 in modern/OPL mode because it doesn't calculate more than one operator in the feedback loop. Algorithm 4 is completely wrong too (3 operators in feedback loop). Mark I mode works because it has special case functions to calculate these (2 ops fb, 3 ops fb).

Bug report from here: https://www.kvraudio.com/forum/viewtopic.php?p=7847236#p7847236

asb2m10 commented 3 years ago

Originally I was about to drop modern and OPL engine, thats why I didn't implement them. Since I kept those, I will put it on the TODO list.

mkruselj commented 3 years ago

Great news, thanks! 🙂