search

asb2m10 / dexed

DX7 FM multi plaform/multi format plugin
GNU General Public License v3.0
2.79k stars 242 forks source link

Algo display small improvements #3

Closed markusthegeek closed 9 years ago

markusthegeek commented 10 years ago

Hi Pascal,

really like this display! couple of small issues are left:

gruss, Markus

asb2m10 commented 10 years ago

Hi Markus,

Algo 7 is fixed, thanks for that.

Yes 14 and 15 look ambiguous, but the little "white" line that tells the operator that has feedback (and that are different between 14 and 15).

I have marked that as an enhancement since it will be "recoded" in future version; with better drawings.

Thanks

markusthegeek commented 10 years ago

Hi Pascal,

cool if you have this on the list for later. what I meant is mostly that at a quick glance one might think that op 5 feeds into 2 instead of 4.

btw, just wanted to mention that I had a lot of fun over the last weeks to work my way through all the cartridges and compile a favorite bank. no further crashes or strange behaviors observed! my main outstanding wishes are MIDI velocity 100 scaler and mod-wheel support ;-)

gruss, Markus

asb2m10 commented 10 years ago

Hi Markus,

Yes, I will have to add artifact to show where to operator is heading.....

I'm happy to see that it is now more stable. Thanks for the feedback; I hope we get a "production ready" plugin by the end of the year and maybe some other DX7 aficionado will join in.

Btw, mod-wheel is now supported. Let me know if you see anything strange.

MIDI velocity will be supported when the "settings" panel will be implemented (in the comming weeks)... But you can try it yourself; just change PluginProcessor.cpp:53 to

normalizeDxVelocity = true;

This velocity issue will be one of the question I have for Raph ; his engine seems to be normalized to 127 not 100.....

Regards, Pascal.

markusthegeek commented 10 years ago

Hi Pascal,

cool, will leave this issue open for the upcoming changes. I like the latest GUI changes for the envelopes!

the normalize velocity option works great, would be cool as a default settings. I compared it vs. the old version with a velocity filter in front.

I am not sure if I can test the modwheel function with the standard patches. would I need to be able to set global function parameters? at least I seem to remember the the original DX7 could not store modwheel control setings per patch.

gruss, Markus

asb2m10 commented 10 years ago

Hi Markus,

Thanks for the feedback about the envelopes. I hope this project will make DX programming fun for once ! :+1:

Seriously, to have a visual feedback really helps knowing what you are doing and helps target to know what you are looking for.

I've just check with Raph and the engine is using a 1-127 velocity range (DX7 II). What he says makes perfect sense: the distortion occurs because the amplitude is calculated per single voice and we need to normalized this to the number of playing voices (16 in DEXED case).

My quick fix for this will be to "floatize" the output summing and then offer the user an internal setting to offer a less "hot" plugin output (let's say -5db). That will "somewhat" emulate the velocity scaling without missing the original dynamics.

There is 2 settings about the mod wheel; on is global (Modulation Wheel -> Pitch) and it is hardcoded to 99 in this plugin. Then, the patch have a "Mod Sens -> Pitch" settings that control the amount of the LFO pitch. Hope this helps.

Regards, Pascal.

asb2m10 commented 10 years ago

Hi Markus,

I've implemented the float voice summing: if the output is too hot, you can simply lower the volume in your DAW and you shouldn't hear any distortion. Let me know if this helps...

markusthegeek commented 10 years ago

Hi Pascal,

to be honest, I do not hear a big difference when comparing old a new versions. the biggest difference is to set normalizeDxVelocity = true. When I do this, the sound is great in the latest version!

I have to play around more with the modwheel, probably should check for patches that have the modulation pre-set. I believe besides pitch there was also amplitude and some kind of fade possible between sounds using the modwheel.

gruss, Markus

asb2m10 commented 10 years ago

Hi Markus,

I've added a volume knob so this time you can lower the output volume of the plugin when there is distortion. If you click at least once on the "OK" button in the params dialog, a configuration file will be saved in [username]\Application Data\DigitalSuburban\Dexed.xml. You can set the "velocity value" by editing this file without having to recompile the project.

Yes, modulation wheel is only supporting pitch right now and amplitude should be implemented in the next version.

The original DX7 has the parameter (range-pitch-amplitude-eg bias) that I don't think I will support in a near future (the DX UI skin is more important). But anyway, the range of the pitch mod wheel is now set to the maximum; i.e. 99.

I have a feeling that amplitude will be more difficult to test since the effect can be in some case very subtile.

Regards, Pascal.

markusthegeek commented 10 years ago

Hi Pascal,

I like all new additions! cool idea with the xml file to save the common settings. works great here on Windows including the velocity value. tried on Linux as well yesterday to see were you write the xml file. however, I get a crash including host when I only try to open the settings dialog! do you need me to attach a debug log?

cool addition also with the global volume!

also checked the mod wheel on Windows, works great now for pitch! that should be fine for now because most of the amp and eg bias settings were probably done by hand for specific patches and not included in the presets. e.g. I had one orchestra patch were you first here the strings and then bring in the brass via modwheel.

gruss, Markus

asb2m10 commented 10 years ago

Hi Markus,

Linux support is underway... I took me some time to fix the hardware issues... Next commit will contain the Linux build.

You have a crash when you are opening the settings dialog ? Is this happening when you have a file, or when the file and directory is not yet created ? I doubt the debug logs will be useful (unless you see something really interesting). What would really help me is a stacktrace of the core dump (see gdb and backtrace). Are you running under root (probably for low latency) ? If it is the case, just check to see if it works with a regular user.

Regards, Pascal.

markusthegeek commented 10 years ago

Hi Pascal,

I have the crash when opening the dialog for the first time. not even clicking on the OK button. all other dialogs display fine including the new About screen.

can look into a core dump later this week.

gruss, Markus

On 2014-03-23 20:45, Pascal Gauthier wrote:

Hi Markus,

Linux support is underway... I took me some time to fix the hardware issues... Next commit will contain the Linux build.

You have a crash when you are opening the settings dialog ? Is this happening when you have a file, or when the file and directory is not yet created ? I doubt the debug logs will be useful (unless you see something really interesting). What would really help me is a stacktrace of the core dump (see gdb and backtrace). Are you running under root (probably for low latency) ? If it is the case, just check to see if it works with a regular user.

Regards, Pascal.

— Reply to this email directly or view it on GitHub https://github.com/asb2m10/dexed/issues/3#issuecomment-38410285.

asb2m10 commented 9 years ago

I'm closing this since the new UI (0.8.0) fixes this.

(If you still have core dump with the 0.8.0, don't hesitate to open a new issue).