search

asbachb / ftp4j

ftp4j is a java implementation of the ftp, ftps and ftpes protocol provided as maven artifact
GNU Lesser General Public License v2.1
58 stars 20 forks source link

Fixed MLSD list parsting #1

Closed acarlsen closed 9 years ago

acarlsen commented 9 years ago

Error parsing name correctly, since the existing code doesn't follow the official spec and thus doesn't allow semicolon in filenames, which should be allowed.

asbachb commented 9 years ago

Hi.Thanks for you pull request. Just to mention it: This is not the official ftp4j repository. I already mailed the original developer to back this repository but got no feedback yet. One solution would be to release a patched release under another groupId.

Regarding your change: It would be nice if you could provide a small example which MLSD response was not successful in order to create a test case. It would be nice of you could review your indentation which is tabs not spaces for this project.

acarlsen commented 9 years ago

Thanks. I know this isn't the official branch. I will fix identation and I have added example of line that failed to comment.

asbachb commented 9 years ago

I squashed both commit and submit your patch to the repo. Thanks for your contribution. I think we should create a bugfix version under a new groupId in order not to break perhaps oncoming "official" releases.