search

asbjornenge / Docker.tmbundle

Dockerfile syntax
MIT License
75 stars 27 forks source link

Various Minor Cleanups #1

Closed infininight closed 9 years ago

infininight commented 9 years ago

Had a request to get this bundle added to the list of bundles installable in TextMate 2. Went through and reviewed the bundle and came up with a few minor cleanups.

We require the bundle to 'be' the root level of the repository, this allow makes checkout easier for those that want to contribute.

Beyond that I made a few minor scoping changes/additions to the grammar. One area I'm not sure works that well is the keyword scopes, ONBUILD should likely have a different scope so it stands out from the other keywords.

Thanks for your work on the bundle!

asbjornenge commented 9 years ago

Woah, thanks a bunch :+1:

I am by no means a tmbundle expert and just threw something together to get it working. Really appreciate this cleanup and PR :dancers: Just tested the new bundle with my ST3 and it works perfectly!

LGTM :rocket:

infininight commented 9 years ago

Just deployed the bundle to the installer, will be available shortly to everyone. Will send out a tweet about it's availability in the morning.

A note about how the updating works: Updates are manually initiated by me rather than automatic, this keeps the frequency down and prevents in-progress work from going out. Just ping me via email/irc/twitter when you want to push a new version out. No worries about the frequency it just takes a second to push a new version.

asbjornenge commented 9 years ago

@infininight very good :rocket: I'll keep an eye out for the tweet :bird: :smile: