search

asbjornenge / Docker.tmbundle

Dockerfile syntax
MIT License
75 stars 27 forks source link

Bring tmLanguage as up to speed as possible #10

Closed princemaple closed 2 years ago

princemaple commented 7 years ago
asbjornenge commented 7 years ago

@princemaple I also added a .gitignore for the .cache files. So be sure to pull :wink:

Also, would it be a huge pain to move the Dockerfile.sublime-syntax into the Syntaxes folder? Does that noe make sense? Keeping it a bit cleaner...?

princemaple commented 7 years ago

Also, would it be a huge pain to move the Dockerfile.sublime-syntax into the Syntaxes folder?

Quick testing suggests that it can be moved. :+1: I'll just need to update my ApplySyntax settings to point to the new location once you have moved it, I use names other than just Dockerfile.

asbjornenge commented 7 years ago

@princemaple feel free to just do both (move+update) in a branch and PR? :stuck_out_tongue: :+1: Going off the grid for a bit (kindergarden pickups etc. etc.) but will be back online this evening :smile:

asbjornenge commented 7 years ago

@princemaple such great work recently my friend :grin: :tada: Thanks a bunch for stepping up and helping out!

What do you think about this linguist repo? Should we make a PR? Or should we perhaps aspire to fix the highlight invalid newlines without a backslash on the previous line issue first?

Actually, if you take a look at their grammars - this repo was updated as early as 9 days ago. So perhaps they have some sort of automatic update feature on new tags or something? Maybe we don't have to do anything :stuck_out_tongue_closed_eyes:

princemaple commented 7 years ago

Looks like they do update the grammars folder from time to time, we don't have to worry about it then. They have this script that gets run every time travis runs, but really updating the repo seems to be a manual job, at least they update all submodules when they do.

https://github.com/github/linguist/blob/master/script/fast-submodule-update https://github.com/github/linguist/blob/master/script/travis/before_install

princemaple commented 7 years ago

If we were to send a PR, it would be a simple git submodule update ...

asbjornenge commented 7 years ago

@princemaple either way is fine with me :smile:

infininight commented 7 years ago

There is no need to do a PR, they pull ever ~4-6 weeks and deploy to Github itself, doing a PR won't speed up this process.

TextMate can be instant though, just deployed the change there. :)

princemaple commented 7 years ago

@infininight thanks for the information