search

asbjornenge / Docker.tmbundle

Dockerfile syntax
MIT License
75 stars 27 forks source link

Filename Madness #16

Closed jnovack closed 4 years ago

jnovack commented 7 years ago

There are many main-stream different conventions to name your dockerfile.

I'm not here to judge, I would just like to know if the filename regex can be changed to match a broader number of Docker ... uhh ... files.

.*[d|D]ockerfile.*

image

I even considered the Windows users, this will even match the Dockerfile at the bottom of the list. Look how gracious I am.

At the very least, perhaps a first_line_match: "^FROM\s\w"?

andyneff commented 7 years ago

With docker 17.06, the first line no longer has to be "^FROM\s\w"

The ARG command can also come first (I'm not sure if any others can), as can a blank line or comment.

So at the very least, I would check for first line FROM|ARG, if that's possible

asbjornenge commented 7 years ago

I'm super swamped in other projects. I've listed you as a maintainer @andyneff, so feel free to just implement these changes if you find some time. You should be allowed to commit to this project directly 😄 👍

blag commented 4 years ago

Fixed.