asc-community / MxEngine

C++ open source 3D game engine
BSD 3-Clause "New" or "Revised" License
1.12k stars 59 forks source link

[Rendering] Fix SSGI algorithm #88

Closed MomoDeve closed 1 year ago

MomoDeve commented 1 year ago

@fall2019 adressing your comment: https://github.com/asc-community/MxEngine/pull/78#issuecomment-1627668639 now it looks like this: image

I agree that sun light should affect the walls, but I also think that scene behind the columns should still be darken if sun is visible

MomoDeve commented 1 year ago

Lum of the frame feels way better than previous. Btw from the screenshot, seems we lose some shadow quality right now. But I guess it's not related to this pr. Approved.

yeah, maybe shadows are a bit off, I am just working on dirlight shadows PR in parallel