search

asc-csa / AlouetteApp

🛰️ Cette application permet aux utilisateurs de filtrer les ionogrammes du satellite Alouette et télécharger les données extraites ou les images des ionogrammes | 🛰️ This application allows users to filter ionograms from the Alouette satellite and download either the selected ionograms’ extracted features or the ionogram images themselves.
https://donnees-data.asc-csa.gc.ca/alouette
Other
7 stars 4 forks source link

Comms Issue #6 #32

Closed coleweusthem closed 3 years ago

coleweusthem commented 3 years ago

The page must have an h1 title in the HTML for search engine optimization.

http://13.88.240.170:8888/alouette/

coleweusthem commented 3 years ago

@nfee006, currently the first piece of text within the 'main' role is inside a h1 tag. I'm not sure I follow their logic here, usually for SEO you would add a tag in the <head> with your other meta data. Do you think they mean we need to add a title tag?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/nfee006"><img src="https://avatars.githubusercontent.com/u/11013061?v=4" />nfee006</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <p>In all likelihood yes but I will send Comms an email this morning to confirm. </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/nfee006"><img src="https://avatars.githubusercontent.com/u/11013061?v=4" />nfee006</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <p>@coleweusthem</p> <p>Paraphrased from Comms: </p> <p>Both a <code><title></code> and a static <code><H1></code> are required. There is currently an H1 but it seems to be created dynamically and only once the page is loaded. Google uses these to index pages so it is vital that they appear on the page at all times. If the page's Javascript (for example) did not load, the existing H1 would not load. </p> <p>Does that answer your question? </p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/coleweusthem"><img src="https://avatars.githubusercontent.com/u/46227765?v=4" />coleweusthem</a> commented <strong> 3 years ago</strong> </div> <div class="markdown-body"> <p>This could be a problem, before the javascript loads we don't know the language the user is on. I can add these, but they won't be able to be language specfic. If thats ok could you identify what you'd like them to say?</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>