search

asc-csa / Scisat-App

🛰️ Cette application permet aux utilisateurs de filtrer les données du satellite SCISAT et de visualiser les données extraites | 🛰️ This application allows users to filter data from the SCISAT satellite and visualize the extracted features.
https://donnees-data.asc-csa.gc.ca/scisat/
Other
6 stars 1 forks source link

Implement the "share this page" button #137

Open nfee006 opened 3 years ago

nfee006 commented 3 years ago

Earlier attempts have been unsuccessful, likely due to interactions between the JS libraries used by wet-boew and by dash (see https://github.com/open-data/ckanext-canada/issues/1191).

image

nfee006 commented 3 years ago
  1. Add the «share this page » button for the two micro applications. NF note: I had done this but it hadn’t worked right. It needs to be added here: https://github.com/asc-csa/Scisat-App/commit/86551e35e7fcceb05288412c8ab64b068876a8f6. https://wet-boew.github.io/v4.0-ci/docs/ref/share/share-en.html

FYI @coleweusthem. Let me know if it's going to be an issue please.

coleweusthem commented 3 years ago

@nfee006, yeah it's not working correctly for me either. It's populating the button but for some reason clicking it does nothing. It's not throwing any errors. I think either you're right and it's a conflict (Although I would expect to see some console errors), or there's a bug in wet-boew, or for some reason, it needs to be run on canada.ca. I'm not sure there's much I can do without so an indication of why it's not working. I'll leave this for last and take another look at it then, see if I can't figure it out

emilinecsa commented 1 year ago

This button works on CSA' web page. I will talk to communications and fix this issue.