node-sass dependency is obsolete

asc-lab / dotnetcore-microservices-poc

Very simplified insurance sales system made in a microservices architecture using .NET Core

https://www.altkomsoftware.com/blog/building-microservices-net-core-part-1-plan/

Apache License 2.0

1.9k stars 681 forks source link

node-sass dependency is obsolete #36

Open ParagRaut opened 4 years ago

ParagRaut commented 4 years ago

I figured out that node-sass dependency mentioned in web package is obsolete now.

I tried to change it to

"devDependencies": { "@vue/cli-plugin-babel": "^3.0.0-rc.10", "@vue/cli-plugin-eslint": "^3.0.0-rc.10", "@vue/cli-service": "^3.0.0-rc.10", "node-sass": "^4.14.0", "sass-loader": "^7.0.3", "vue-template-compiler": "^2.5.16" },

then web-vue built successfully

witek1902 commented 4 years ago

Thanks @ParagRaut ! Could you create pull request with this change?

ParagRaut commented 4 years ago

Sure, I’m pretty new to this repository and I was just checking it out on docker. I see frontend container running but spitting no logs with my changes. Maybe I’m not accessing correct front end url, can you specify it? So that I can test it first and then create pull request