ascendedguard / sc2replay-csharp

C# Library for parsing Starcraft 2 Replay files
MIT License
56 stars 20 forks source link

Copyright text, bug fixes, and hallucinations #27

Closed ghost closed 12 years ago

ghost commented 12 years ago

~~

manytwo commented 12 years ago

Hello man, I was trying your parser and no way to get playerEvents in replay var. Is there trouble with event? I just want to show build order from each players. Can u help me with code, or say me if there is trouble? ( Replay replay.playerEvents ever null, may i construct it myself, or parse replay and build myself an event list?)

Reallly nice job, i hope u ll continue that nice work.

ascendedguard commented 12 years ago

Hmm... surprised i've overlooked this pull request for this long. I need to get this merged in if I haven't o.o

Meanwhile, has anyone verified that this is still working with 1.5.3? I'll be sure to test it over the next few days as I'll be using this library in an updated app.

manytwo commented 12 years ago

2012/9/23 Will Eddins notifications@github.com

Hmm... surprised i've overlooked this pull request for this long. I need to get this merged in if I haven't o.o

Meanwhile, has anyone verified that this is still working with 1.5.3? I'll be sure to test it over the next few days as I'll be using this library in an updated app.

— Reply to this email directly or view it on GitHubhttps://github.com/ascendedguard/sc2replay-csharp/pull/27#issuecomment-8800194.

Hi, after some test, is see a problem with mpqLib: It try to find c:\projects\mpqlib\mpqlib\mpq\archive.cpp (error -> MpqLib.dll!MpqLib.Mpq.CArchive.ExportFile(String FileName, byte[] FileData) Line 237

debug on replay.cs line 183 if (!noEvents) { const string CurFile = "replay.game.events";

                    var fileSize = (from f in files where

f.FileName.Equals(CurFile) select f).Single().Size;

                    var buffer = new byte[fileSize];

          error line ->          archive.ExportFile(CurFile, buffer);

                    replay.PlayerEvents =

ReplayGameEvents.Parse(replay, buffer); }

With try catch, error dont break program. Is there an absolute path on mpqLib? something else: after few tests, i can parse a replay in this path, only on admin mode (windows 7). May be mpqlib cant write temporary file?

i Hope this can help you, and sorry about my English, i may work on my vocabulary! And.. GL HF^^