If the user doesn't have permission to read the replay file, an incorrect exception is thrown

ascendedguard / sc2replay-csharp

C# Library for parsing Starcraft 2 Replay files

MIT License

56 stars 20 forks source link

If the user doesn't have permission to read the replay file, an incorrect exception is thrown #3

Closed ascendedguard closed 13 years ago

ascendedguard commented 13 years ago

MPQEditor.exe will silently fail and not write the replay.details file out if the user doesn't have permission. Either the file permissions should be checked before running MPQEditor.exe, or the replay.details file should be checked if it exists, and a proper exception thrown if it doesn't.

ascendedguard commented 13 years ago

Not sure if this still applies since MPQEditor.exe is no longer used. An exception very well may be thrown now, but is it appropriate?

ascendedguard commented 13 years ago

This has been fixed. An UnauthorizedAccessException is thrown by BinaryReader.