search

aschampion / diluvian

Flood filling networks for segmenting electron microscopy of neural tissue
MIT License
23 stars 13 forks source link

Coordinate transforms: #17

Closed pattonw closed 5 years ago

pattonw commented 5 years ago

The coordinate transformations were confusing me when I started out. I changed them to have the following form: Given coordinate systems A and B, and coordinates a in A and b in B, the function A_to_B(a) = b.

This is more of a personal preference so keep whichever one you like better.

aschampion commented 5 years ago

This makes sense -- I'm wondering why I had them reversed in the first place. Going to give myself a few hours to try to recall before reviewing.

aschampion commented 5 years ago

After looking at this the only reasons I can imagine for my original nomenclature are:

  1. Coordinates within a volume were called world
  2. A_to_B meant applying the transformation to the A space to a coordinate from the B space.

Neither of these make much sense, so I'm fine merging this.

aschampion commented 5 years ago

Docstring is good, but there's whitespace breaking the lint.