search

aschampion / diluvian

Flood filling networks for segmenting electron microscopy of neural tissue
MIT License
23 stars 13 forks source link

N5Volume #21

Closed pattonw closed 5 years ago

pattonw commented 5 years ago

Added support for an N5 volume. Also added a test for the N5 volume.

Relies on pyn5 which has been added to the dependency list

pattonw commented 5 years ago

This feature won't pass the python 2.7 and 3.4 tests since it relies on pyn5 which isn't available on either of them. Maybe N5Volume should be put behind a feature flag or something. Not sure what the best way to do that is.

aschampion commented 5 years ago

We're dropping Python 2 support and I'm also fine with dropping 3.4 as its end of life release is later this month. We should add 3.7 to build matrix/tox, though.

pattonw commented 5 years ago

Hmm, it looks like there's issues with the tensorflow version in python 3.7

aschampion commented 5 years ago

Ugh, I forgot TensorFlow didn't support python 3.7 until version 1.13. I'm not ready to update diluvian that far yet and will do so in a separate PR.

For now amend the branch to not add 3.7.

pattonw commented 5 years ago

Sounds good. I removed python 3.7 and squashed the commits down. Should I start a pull request with the travis/tox changes in another branch and make a note that tensorflow needs to be upgraded so we don't forget?

aschampion commented 5 years ago

Should I start a pull request with the travis/tox changes in another branch and make a note that tensorflow needs to be upgraded so we don't forget?

Sounds good. This PR looks good, so merging.