search

aschera / Capstone-Project-Colmar-Academy

Website for a fictional school, Colmar Academy.
0 stars 0 forks source link

HTML #2

Closed Tzuridis closed 6 years ago

Tzuridis commented 6 years ago

Great job on your HTML but you should use divs more as dividers/wrappers. You created the sections but need to apply identifiers to those sections. Other than that your HTML looks great, especially with your use of notes and on implementing video controls which is something not a lot of people do.

aschera commented 6 years ago

What do you mean when you say 'apply identifiers to those sections'. My sections have classes. for example:

Tzuridis commented 6 years ago

Place IDs also look up the differences between class and id and when you should use either.

On Mon, Jul 2, 2018, 3:04 AM C.B. notifications@github.com wrote:

What do you mean when you say 'apply identifiers to those sections'. My sections have classes. for example:

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/aschera/Capstone-Project-Colmar-Academy/issues/2#issuecomment-401691199, or mute the thread https://github.com/notifications/unsubscribe-auth/ASa8uJ_P5j-IlgrWGeWFLyXXA2CBunlVks5uCcX9gaJpZM4U-aL0 .