search

aschn / drf-tracking

Utils to track requests to Django Rest Framework API views
http://drf-tracking.readthedocs.org/
ISC License
366 stars 95 forks source link

Fix missing query_params on Put/Post/Patch requests. Update tox tests to include django 2.2.6 and drf 3.10.3 versions #142

Open lingster opened 4 years ago

lingster commented 4 years ago

Hi, I'd like to submit a PR to update this package. Also would you like some help to push a new version to pypi?

avelis commented 4 years ago

@lingster I can do my best. I haven't pushed a release in a while but can look into it.

lingster commented 4 years ago

@avelis thanks for replying, created the following PR: #143. Unit tests are passing. Pushing a release should also resolve #134

lingster commented 4 years ago

@avelis I've also included in the PR fix and tests for an issue where the query params are not stored for PUT/POST/PATCH requests. could you kindly include this for the release?

avelis commented 4 years ago

@lingster Can you look into why there is one failing test. Looks to be only on one configuration. If it's benign I can merge it in. https://travis-ci.org/aschn/drf-tracking/jobs/601860781?utm_medium=notification&utm_source=github_status

lingster commented 4 years ago

@avelis that should be fixed. I don't have multiple python versions on my system so i am relying on the CI to confirm everything is working.