Add tvOS framework target (for tvOS carthage support)

aschuch / StatefulViewController

Placeholder views based on content, loading, error or empty states

MIT License

2.14k stars 149 forks source link

Add tvOS framework target (for tvOS carthage support) #21

Closed mathiasnagler closed 8 years ago

mathiasnagler commented 8 years ago

This PR Adds a tvOS framework target. The new consists of the exact same source files and even shares the Info.plist with the iOS target. I also added a new shared scheme so the tvOS target can be built using Carthage.

Finally, I added a platform badge to the README.md to mark tvOS and iOS as supported platforms.

Note: tvOS CocoaPods support is already handled in #16.

mathiasnagler commented 8 years ago

Is there any update on this? Does this need additional work?

aschuch commented 8 years ago

Thanks. Looks good to me. :sparkles: Would it be possible to name the targets StatefulViewController-iOS and StatefulViewController-tvOS respectively? This matches the style of the rest of my OSS projects.

Other than that, I am :+1: to merge.

mathiasnagler commented 8 years ago

Hi @aschuch,

I renamed the targets and I also renamed the shared schemes to follow the same naming. Let me know if there are still any issues and I will update the PR.

aschuch commented 8 years ago

Thanks!