explicitly set Swift Version for tvOS

aschuch / StatefulViewController

Placeholder views based on content, loading, error or empty states

MIT License

2.14k stars 149 forks source link

explicitly set Swift Version for tvOS #36

Closed Lutzifer closed 7 years ago

Lutzifer commented 7 years ago

otherwise, the carthage build command for tvOS (/usr/bin/xcrun xcodebuild -project Example.xcodeproj -scheme StatefulViewController-tvOS -configuration Release -sdk appletvos ONLY_ACTIVE_ARCH=NO BITCODE_GENERATION_MODE=bitcode CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= CARTHAGE=YES clean build) fails

aschuch commented 7 years ago

This should be fixed on tag 2.0, the swift2.3 branch is not up to date and should probably be deleted.

Lutzifer commented 7 years ago

thx

Lutzifer commented 7 years ago

It is still broken for tvOS in the 2.0 release, only fixed for iOS.

aschuch commented 7 years ago

Running carthage build --no-skip-current --toolchain com.apple.dt.toolchain.Swift_2_3 actually builds fine for me. Have you tried adding the toolchain explicitly?

Lutzifer commented 7 years ago

I did not try that. This surely is one way to fix it. The targets differ in this point nonetheless, so it could be a good addition to the Readme.

Lutzifer commented 7 years ago

cleaning up my pull requests:

carthage update --platform tvOS,iOS works fine for Release 3.0.1.

Closing this