Boxes.el: Fixes for incorrect Customize, compiler warnings & obsolete code.

[Mike-Woolley]

● Customisation option 'boxes-known-modes' was being incorrectly added to the internal Emacs 'Customize' meta-group.

● Fixed by creating a new 'Boxes' group for use by this package. Note that backwards compatibility is preserved for those who have already customised this option.

● Added type declaration for 'boxes-known-modes', which as well as fixing a compiler warning, enables completion and type-checking on user-entered values.

● Put the other user-settable variables as customisation options in the new 'Boxes' group.

● Fixed a bunch of compiler warnings.

● Removed / modified obsolete or unnecessary code (like requiring the deprecated package 'cl' etc).

[tsjensen]

That looks great - thank you!

@zerotao Do you also want to take a look before we merge?

[Mike-Woolley]

Thanks @tsjensen, I commented the commit diff to explain my changes 😊

[tsjensen]

Thanks @tsjensen, I commented the commit diff to explain my changes 😊

Sure, don't worry, we'll just give @zerotao a few days, in case he wants to take a look.
I'm sure he'll ask back if anything is unclear to him.

[tsjensen]

Ok, I'll merge, then. Thanks a lot, @Mike-Woolley!

[Mike-Woolley]

Thanks @tsjensen!

I was thinking it would be good to put boxes.el into one of the Emacs package repositories, which would make it easier for Emacs users to find.

It also means Emacs users could automatically install the boxes binary and lisp support with a simple elisp declaration like this 😊

(use-package boxes
  :ensure t
  :ensure-system-package boxes)

The code for boxes.el would stay in this repository and when changes are made a package update would automatically be generated and published.

I could do this if you agree it's a good idea?

Thanks, Mike

[tsjensen]

That would be fantastic! ⭐

[Mike-Woolley]

Ok, I will make it so 😊

[zerotao]

Sorry I was down with a stomach bug. Looks great to me!