ascii-boxes / boxes

Command line ASCII boxes unlimited!
https://boxes.thomasjensen.com/
GNU General Public License v3.0
613 stars 75 forks source link

Yoink the cow and tux from cowsay #91

Closed Davidy22 closed 3 years ago

Davidy22 commented 3 years ago

The original reason I ended up finding this was that cowsay and every cowsay reimplementation doesn't support different width characters, and the odds of cowsay getting an update are very low. This patch steps on cowsay's toes and provides a cow and tux that doesn't break for chinese, japanese, korean users so they can finally fully join in the pointless fun. The speech bubble is a little large on small text, couldn't figure out how to have a non-scaling underhang below an elastic region.

tsjensen commented 3 years ago

Thanks! It's a nice idea to get cows on board.

Until now, we have kinda steered clear of cows (and rather adopted unicorns instead) in order to avoid licensing issues.

But I'll see if I can find something definitive on whether we can use the cow and tux. Or maybe we can even get permission from Tony Monroe himself, then we'd be absolutely safe.

Davidy22 commented 3 years ago

I did say yoink, but Monroe did release his code fully for others to pick up the mantle and boxes probably has as much a claim as any project that straight up inherits the cowsay name to use the templates inside

tsjensen commented 3 years ago

Thanks for the link. I can't see if user tnalpgge is Tony Monroe, tho. If he really did officially release it into the public domain, that's great! Once we find proof of that, we'd be good to go. I'll keep looking; currently, things are a bit slower on my side as I am away from the computer for a time.

tsjensen commented 3 years ago

The cowsay man page lists his email. I'll try and write to him. 😇

tnalpgge commented 3 years ago

If it's worth anything, I approve this pull request :shipit: 😄

tsjensen commented 3 years ago

Thank you very much @tnalpgge for your support! 😎👍

@Davidy22 Tony responded to my email to the address from the cowsay man page within minutes, so we are now go! 🚀

Davidy22 commented 3 years ago

Github online editor's a lot nicer than I remember, four clicks to fold in all the adjustments. Still not sure how to get the text box to scale down to text shorter than the cow is long without changing the cowsay design but it probably won't come up much anyways.

tsjensen commented 3 years ago

The sizing and placement of the speech bubble is constrained by our grid system. You basically have two options:

Davidy22 commented 3 years ago

Yeah, that's just about what I surmised, was hoping there was something else. Classic cow's always under the bubble, picked that over a completely properly scaling bubble