asciidisco / grunt-imagine

Grunt tasks for optimizing & inlining images
MIT License
153 stars 21 forks source link

Update for grunt@0.4.1 #29

Closed alpadev closed 11 years ago

alpadev commented 11 years ago

Hey there,

just came around looking for a better way to compress my images. I found your great addition but to bad it wasn't working out of the box. Since you are to busy atm to update it by yourself and there were just some minor fixes I thought I might do it :)

There you go. Updated and working again :)

Running "pngnq" task

Compressed 2 files Uncompressed size: 8.27kb, Compressed size: 1.79kb, Savings: 78.34%

Running "pngmin" task

Compressed 2 files Uncompressed size: 8.27kb, Compressed size: 0.16kb, Savings: 98.04%

Running "gifmin" task

Compressed 2 files Uncompressed size: 0.88kb, Compressed size: 0.11kb, Savings: 87.07%

Running "jpgmin" task

Compressed 1 files Uncompressed size: 554.13kb, Compressed size: 554.13kb, Savings: 0%

Running "inlineImg" task

Inlined: 1 Images in file: src/whoot.css

Running "sprites:icons36" (sprites) task

Generated image: src/icons36.png & CSS file: src/test.css

Done, without errors.

alpadev commented 11 years ago

Hey dude!

If you don't mind I'd further update your code. Nope I don't want to steal neither take the ownership for it but I'm taking this opportunity to actually enhance my skills with node/grunt :)

alpadev commented 11 years ago

There you go - green with grunt@0.4.1 :D

asciidisco commented 11 years ago

Really, really awesome work. I simply do not have the time to care about that little lovely plugin anymore :(

So thank you for your help, I added you as a colaborator. Could you please tell me your npm username, so that I can give you the rights to publish new versions?

asciidisco commented 11 years ago

Btw.: I pushed the changes to npm as version 0.3.0 ;)

alpadev commented 11 years ago

I'm glad you like my work :+1: To be honest it's the first contribution like that for me since I'm still some sorta beginner (and thus have no npm account yet '-.- ... guess It's about time). But I try to finally give something back to the community also this helper comes in very handy :)

I already have some plans for it to let you know - like patching the inlineimg generation (I found an unused var to probably implement the dest option but I'm already at it to get that thing into it :)) Also I'd have plans to rebuild the structure a bit to wipe some code repetition out. After that probably I will add truepng & zopfli to the supported modules :)

alpadev commented 11 years ago

Btw. what is your desired code styling because right now it's a little bit messy.. (2s/4s tabs mixed)

alpadev commented 11 years ago

Also I assigned that cheerio task to me if you don't mind :) Never heard of it before though I guess it won't be to hard to get that thing done