asciidisco / grunt-imagine

Grunt tasks for optimizing & inlining images
MIT License
153 stars 21 forks source link

Fix #34 by making the image path relative to the css path #35

Closed LaurentGoderre closed 11 years ago

asciidisco commented 11 years ago

@LaurentGoderre You seem actively working with grunt-imagine while I´m not at the moment, do you wan't to be added as a contributor here on github & package maintainer in npm like @alpadev?

alpadev commented 11 years ago

@asciidisco About #32 I just want to be sure to not forfeit your trust :) It's a nice real world example to learn and work with and also a great chance for me to evolve.. though I wish I'd have more time for it atm.. x-mas season.. Also I hope I don't commit to much crap to you guys.. at least I try to :3

Seems to be a good idea to have @LaurentGoderre on board nice additions so far.. lil' envious (:

btw. if you still feel you want to add me on npm - I'm using the same name there (yep I finally did..)

LaurentGoderre commented 11 years ago

Hey @asciidisco it would be an honor but I do I kind of feel like @alpadev, I don't want to screw anything up.

alpadev commented 11 years ago

To speak for myself your additions are very welcome.. subset support is nice to have these days :+1: @LaurentGoderre

LaurentGoderre commented 11 years ago

Alright then... do you have a standard waiting period for other contributors to comment?

alpadev commented 11 years ago

I don't think so :P

asciidisco commented 11 years ago

@alpadev I added you now as a maintainer in npm, you should now be able to spit out releases on you own. @LaurentGoderre You are now a collaborator on github. Just give me your npm user name & you are also allowed to push new versions to npm :)

To both of you, thank you very much for bringing this tool back to life. I wish I could contribute something at the moment. Regarding to this "I don't want to screw anything up" thing, I know that the code is super crappy, so any addition from your side can just make it better ;)

By the way, are you guys on twitter? Would like to thank you in public for working on imagine :D

LaurentGoderre commented 11 years ago

My npm username is laurentgoderre and my Twitter is the same as this one