asciidisco / grunt-imagine

Grunt tasks for optimizing & inlining images
MIT License
153 stars 21 forks source link

Development #43

Closed alpadev closed 10 years ago

alpadev commented 11 years ago

I made some misc changes. The major ones are:

@LaurentGoderre you still pull request your additions for others to sign it I guess? If thats the appropriate behavior let me know so I'll start doing the same :)

alpadev commented 11 years ago

Don't merge yet. Took it to easy with the output generation. Rewriting it.

alpadev commented 11 years ago

Tested with:

jpgmin: {
      src: ['../bundles/<%= pkg.bundleName %>/img/*'],
      dest: '../public/<%= pkg.bundleName %>/img',
      quality: 80 // use lossy JPEG compression at 80% quality
    },

Running "jpgmin" task

Compressed 31 files Uncompressed size: 21937.55kb, Compressed size: 10863.95kb, Savings: 50.48%

Having them correctly output to the img folder under public.. .. but this time other patterns like .jpg, test/.jpg, test//.jpg, test/{a,b}/_.jpg etc. should work as well. The first dynamic pattern marks the beginning_ of the path/file that is output to the destination (paths are kept intact - it's not cutting them anymore, at least I hope so).

LaurentGoderre commented 11 years ago

We use PR on our project even if we have push access. It gives a chance to others to review it and a second validation from travis

alpadev commented 10 years ago

I'll close this and gonna separate them into single pulls in the near future. I think some additions are really useful. Just recently had the prob with case-sensitive file extensions. :P