search

asciidisco / grunt-imagine

Grunt tasks for optimizing & inlining images
MIT License
153 stars 21 forks source link

Replaced the jQuery dependency with Cheerio to solve #28 #44

Closed LaurentGoderre closed 10 years ago

LaurentGoderre commented 10 years ago

node-jquery causes issues for Windows user because it depends on contexify which requires building some code natively. Cheerio provides the same need functionality for this project without the problems in Windows and without the overhead of a full DOM implementation.

Furthermore, this resolves an issue with the existing code which has a problem if an image in comments has the same source as an uncommented image, the uncommented image is not modified. The new approach ignoes comments.

LaurentGoderre commented 10 years ago

@asciidisco @alpadev any issue with merging this ?

alpadev commented 10 years ago

Sorry been really busy that week - told ya.. xmas(-mess) season. About cheerio I don't think it harms.. I had it already replaced on the development pull request (#43 & #3) and it's working fine so far for over about two weeks now. Your implementation (compare https://github.com/asciidisco/grunt-imagine/commit/c148ec18009d1408bd3391bb98346dbf52b37dce) though looks better since it makes use of the cheerio module as it's intended I think.

LaurentGoderre commented 10 years ago

@alphadev, the only reason I did is because in a rar edge case where you would have an image in html comment and an image with the same path after and outside the comment, the commented image would get inlined but not the actual image

LaurentGoderre commented 10 years ago

thanks for merging!

alpadev commented 10 years ago

Ah I see that makes definitely sense. As I said your 's looking more clean and now there is no doubt 'bout that. :+1: :) Merging that into dev (#43) now (https://github.com/asciidisco/grunt-imagine/commit/40590f5322fbf55a1d56c2e0a07ada4d08158663). If you could have a checkout and play around a bit, I'd really appreciate that. So far it works for me but I like to have some feedback from a different source.

LaurentGoderre commented 10 years ago

Sounds good! I'll try to get on that on Monday

alpadev commented 10 years ago

That'd be awesome, thks :)