search

asciidisco / grunt-imagine

Grunt tasks for optimizing & inlining images
MIT License
153 stars 21 forks source link

spritesheet generation is faulty #63

Open yonidor opened 9 years ago

yonidor commented 9 years ago

I have an issue where i generate sprites using the sprites task, and the output has different colors on some of the images pixels. This means that the spritesheet generation tool manipulate with the original images somehow.

asciidisco commented 9 years ago

This definitely looks like a bug in grunt-imagine. And yes, of course it is "manipulating" the images somehow. It reads the image contents & then generates a new one, technically it is converting all of the image sources into one new big image (using some weird trickery & canvas elements in PhantomJS, because that is the only "package" you can use to manipulate images that can be downloaded as a binary & works on all systems).

Can you reproduce this issue with images other than the ones you experienced it first. Second question would be, if you could send me some sample image, so that I can reproduce & debug it.

LaurentGoderre commented 9 years ago

I wonder if the color space or bit depth could have an impact as well.

asciidisco commented 9 years ago

Most probably, could also be some gibberish the tool added, the png was created with.

yonidor commented 9 years ago

Well, it was a long time ago, i do not remember the exact set of images that had the problem. anyway, i would just like to add that when using grunt-spritesmith to generate spritesheets, when using it's phantomJs engine, the same issue happened. so i assume it has to do directly with Phantom.

asciidisco commented 9 years ago

@yonidor That´s some useful information, thank you.

It´s more a "well, what can go wrong" solution, but maybe we should upgrade to Phantom2 & hope that issues like this are resolved in its engine.