search

asciidisco / grunt-qunit-istanbul

Run QUnit unit tests in a headless PhantomJS instance & generate some nice code coverage metrics using Istanbul.
MIT License
33 stars 21 forks source link

Replace QUnit.jsDump with QUnit.dump #68

Closed sutara79 closed 5 years ago

sutara79 commented 7 years ago

Hello. An error occurred when I'm using "grunt-qunit-istanbul" and QUnit 2.3.2. I got a message below.

>> PhantomJS error:
>>  TypeError: undefined is not an object (evaluating 'QUnit.jsDump.parse')

In QUnit 2.x, "QUnit.jsDump" is now replaced with "QUnit.dump". https://qunitjs.com/upgrade-guide-2.x/#replace-qunit-jsdump-with-qunit-dump

Originally jsDump was a standalone library imported into QUnit. It has since evolved further within the library. To reflect that, the property was renamed to QUnit.dump.parse.

I edited grunt-qunit-istanbul/phantomjs/bridge.js, then my problem was resolved. But it does not work on Node.js: 0.8. https://travis-ci.org/sutara79/grunt-qunit-istanbul/

Do you have any good idea? Thanks.

doronwix commented 6 years ago

this pull request is fixing a critical issue, can it be merged?

fsmeier commented 5 years ago

@asciidisco Can we merge this? - This repo is the only one i find so far which is doing the instanbul-job but it is not maintained anymore and therefore outdated. It seems that this PR fixes at least the biggest issue for now.

asciidisco commented 5 years ago

@IMM0rtalis Wow, I really thought that no one uses this anymore. Sure, I'll merge & republish

fsmeier commented 5 years ago

@asciidisco yeah, i think this repo is used quite a lot yet, see the weekly downloads: https://www.npmjs.com/package/grunt-qunit-istanbul and all the forks :p

I think it would be nice to still maintain this repo. In other github issues mentioning this repo it is said that grunt-qunit-istanbul is not maintained anymore at all.

Thx for the merge :)

asciidisco commented 5 years ago

@IMM0rtalis Sure thing, just released it as 1.1.0 If you're still using this I can give you Repo access if you like...

fsmeier commented 5 years ago

@asciidisco Wrote you via mail.