asciidisco / plugin.video.netflix

Inputstream based Netflix plugin for Kodi
MIT License
1.24k stars 225 forks source link

DD PLUS 640KB #429

Open chicc0 opened 6 years ago

chicc0 commented 6 years ago

Netflix added for some titles audio ddplus 640kb. Would it be possibile to add it?

armin884 commented 6 years ago

Anyone knows the profile code for 640k and Atmos Audio?

chicc0 commented 6 years ago

ddplus-atmos-dash

armin884 commented 6 years ago

Thanks, but none of these contentProfile ddplus-atmos-dash , dd-pp-5.1-dash , dd-sq-atmos-5.1-dash works for me...

chicc0 commented 6 years ago

Profile for atmos is ddplus-atmos-dash but only very limited Movies have atmos audio

ShareScene commented 5 years ago

armin884 have you tried this one? 'ddplus-5.1hq-dash',

rguedes commented 5 years ago

armin884 have you tried this one? 'ddplus-5.1hq-dash',

That profile is for 640kbps DD Plus, but stopped working at 2 weeks ago.

ShareScene commented 5 years ago

@rguedes do you know the new one?

rguedes commented 5 years ago

@rguedes do you know the new one?

Not yet

rguedes commented 5 years ago

@rguedes do you know the new one?

Is the same profile. But ionly available in some countries with the Ultra account, not the Premium.

ShareScene commented 5 years ago

okey, I understand, thx ;)

kyvaith commented 5 years ago

I apologize for my ignorance, but how do I add audio and video profiles? I would like to add the ddplus-atmos-dash profile in the latest release of the plugin. Thanks.

EDIT:

I've added ddplus-atmos-dash into manifest_request_data -> profiles in MSL.py and now I can see in manifest.json that atmos stream is available for selected movie:

"audioTracks": [
          {
            "channelsCount": 6,
            "language": "Englisch [Original]",
            "type": "AUDIO",
            "channels": "5.1",
            "downloadables": [
              {
                "downloadableId": "15765169",
                "isEncrypted": false,
                "contentProfile": "ddplus-atmos-dash",
                "urls": {

But I don't have an option to select Atmos stream in audio dialog box while playing. Only 5.1 and 2.0 streams.

caphm commented 5 years ago

@kyvaith I guess this needs additional handling when transforming the NF manifest to DASH format. I'll look into it.

kyvaith commented 5 years ago

@caphm , thank you. This is the only thing missing on Nvidia Shield (while Shield officially supports Atmos but not in Netflix), so it would be great to have a perfect android box.

kyvaith commented 5 years ago

@caphm Due to the fact that the problem related to the transition of Netflix to API v2 has been resolved, will you find a moment to look at Atmos support? It's time to order Christmas gifts and this is the last thing that keeps me from choosing Nvidia Shield TV for a gift ;) Thanks!

rguedes commented 5 years ago

To Atmos add this profile: ddplus-atmos-dash To 640 audio add this profile: ddplus-5.1hq-dash

But you need an Ultra account to audio 640kbps. Only the profile not works.

kyvaith commented 5 years ago

@rguedes thanks for reply, but like I wrote before:

I've added ddplus-atmos-dash into manifest_request_data -> profiles in MSL.py and now I can see in manifest.json that atmos stream is available for selected movie:

"audioTracks": [
          {
            "channelsCount": 6,
            "language": "Englisch [Original]",
            "type": "AUDIO",
            "channels": "5.1",
            "downloadables": [
              {
                "downloadableId": "15765169",
                "isEncrypted": false,
                "contentProfile": "ddplus-atmos-dash",
                "urls": {

But I don't have an option to select Atmos stream in audio dialog box while playing. Only 5.1 and 2.0 streams.

It doesn't work. @caphm suggests:

@kyvaith I guess this needs additional handling when transforming the NF manifest to DASH format. I'll look into it.

But I don't even know where to start digging this issue. I even can't find a Dolby Atmos manifest specification anywhere online.

BTW - I don't need the 640KB stream, just the regular one.

Thanks.

paxter commented 5 years ago

To 640 audio add this profile: ddplus-5.1hq-dash

But you need an Ultra account to audio 640kbps. Only the profile not works.

Already tried that. But does not work. I guess it's related to your geolocation too (I am on ultra).

kyvaith commented 5 years ago

@caphm I would love to hear some update on this. Would you find time to look at atmos support?

caphm commented 5 years ago

@kyvaith Sorry, I'm incredibly busy currently and don't have time to work on this project.

armin884 commented 5 years ago

When adding ddplus-5.1hq-dash to profiles for 640k audio i get Viewable not available - validation error . My account type is premium ultra.

{u'from': u'nq_cadmium_pbo_manifests@1.14.9/pbo-client@1.14.9', u'version': 2, u'serverTime': 1544495478694L, u'id': 15444954768350L, u'error': {u'code': u'FAIL', u'bladeRunnerMessage': u'manifest/pbcs-105: Viewable not available - validation error. (nq_cadmium_pbo_manifests@1.14.9/pbo-client@1.14.9)', u'errorNccpCode': 0, u'pboc': True, u'detail': u'manifest/pbcs-105: Viewable not available - validation error. (nq_cadmium_pbo_manifests@1.14.9/pbo-client@1.14.9)', u'errorExternalCode': 0, u'errorDisplayMessage': u'This title is not available to watch instantly. Please try another title.', u'nccpError': {}, u'bladeRunnerCode': u'105', u'errorActionId': 3, u'errorSubCode': 0, u'errorReasonCode': 0, u'display': u'This title is not available to watch instantly. Please try another title.'}}

That ddplus-atmos-dash profile is working for english audio but only with 384kbps bitrate...

Format                                   : E-AC-3 JOC
Format/Info                              : Enhanced AC-3 with Joint Object Coding
Commercial name                          : Dolby Digital Plus with Dolby Atmos
Codec ID                                 : ec-3
Bit rate mode                            : Constant
Bit rate                                 : 384 kb/s
Channel(s)                               : 6 channels
Channel layout                           : L R C LFE Ls Rs
kyvaith commented 5 years ago

@armin884 Can you please tell me what have you done to add a ddplus-atmos-dash and make it working? Also how can I get a debug info about audio channels like the one you've posted? I've tried to simply add a profile but it doesn't work for me.

armin884 commented 5 years ago

@kyvaith i don't know if kodi plays atmos sound, i just added 'ddplus-atmos-dash' to audio profiles and looked up the manifest file for download link. That audio info was made with mediainfo from the downloaded file...

Ch1llb0 commented 5 years ago

I added the lines talked about here to MSL.py:

    manifest_request_data = {
        'method': 'manifest',
        'lookupType': 'PREPARE',
        'viewableIds': [viewable_id],
        'profiles': [
            # Video
            'playready-h264bpl30-dash',
            'playready-h264mpl30-dash',
            'playready-h264mpl31-dash',
            'playready-h264mpl40-dash',

            # Audio
            'heaac-2-dash',
            'ddplus-5.1hq-dash',
            'ddplus-atmos-dash',

But there's no Atmos sound... Trying to test this with Iron Fist Season 2 which has English Atmos audio. What am I doing wrong?

Essam315 commented 5 years ago

@Ch1llb0 You need to modify MSLv2.py not MSL.py in Netflix plugin 0.13.21, for quick testing just replace all "ddplus-5.1-dash" with "ddplus-atmos-dash", test with the first episode.

https://help.netflix.com/en/node/64066

Ch1llb0 commented 5 years ago

Just tested... It signals Atmos to my AVR, but it recognizes that it's just DD+.

kyvaith commented 5 years ago

@Ch1llb0 Just to clarify - it's recognized as DD+ in Kodi or by your AVR? If it's Kodi its kind of ok, because Atmos is an object based stream, not channel based. Anyway, it would be great to have a native, "conscious" support of Atmos streams in netflix addon - at least make ddplus-atmos-dash primary over ddplus-5.1-dash when available.

Ch1llb0 commented 5 years ago

@kyvaith, by my AVR (Denon AVR-X4300H which is supposedly doing a stream analysis of audio data every time)... So, it's signalled Atmos, but just "sees"/plays DD+. When choosing "Surround" as the upmixer this would normally lead to automatic Atmos playback when the audio stream has Atmos 3D audio information embedded. Otherwise it'll just play DD+ plus the Dolby upmixer - which is happening here with the first episode of season 2 of Iron Fist (it should have an Atmos track).

kyvaith commented 5 years ago

Ok, so this is probably the case mentioned by @caphm:

@kyvaith I guess this needs additional handling when transforming the NF manifest to DASH format. I'll look into it.

Your AVR receives DD+ signal with incomprehensible metadata for Atmos mapping. I have no idea about NF and real Atmos metadata schemas (can't find any documentation on internet), so I don't know what is the difference.

I'm also looking for Devs help in this matter.

Ch1llb0 commented 5 years ago

Any idea maybe, @graham8? You're more familiar with the technical side of the audio formats...

graham8 commented 5 years ago

Over my paygrade, sorry.

kyvaith commented 5 years ago

I read somewhere that the Nvidia Shield doesn't run MS12 (Dolby audio technology required by Netflix to receive Atmos from NF). Without MS12 the Netflix can't send atmos. Does anyone know if it is a blocker that prevents the addition of Dolby Atmos support? Or is there a workaround?

Raboo commented 5 years ago

Hi, I don't care about Atmos. I run Kodi under MacOS, passthrough works with regular files. But with Netflix I just get a transcoded multichannel. Is it possible to get DD+ passthrough and let my receiver handle the audio?

kyvaith commented 5 years ago

Digging deeper, I realized that starting form Leila, Kodi is using its own IEC packer instead of the Shield's one. This could be a reason why JOC is not passed through to receiver. I'm waiting for a Dev from Kodi team to provide me a forced raw passthrough build of Kodi to test if Atmos will work with it. More info here: https://forum.kodi.tv/showthread.php?tid=335477

kyvaith commented 5 years ago

I can confirm that forced raw version od Kodi (using platform IEC packer) is working with Atmos on Nvidia Shield with Netflix plugin. You can grab forced raw version from here: http://mirrors.kodi.tv/test-builds/android/

Ch1llb0 commented 5 years ago

What implications does this have for further developement, especially on other platforms? Dolby Atmos output is not working in OSMC Vero 4K here either...

farhanito commented 5 years ago

@kyvaith Is there anything else needed to do besides using forced raw Kodi version? Tried on Mi Box and Fire TV Stick 4k, NF Atmos isn't showing up.

kyvaith commented 5 years ago

@farhanito If you're using force raw version, your box needs to have a JOC metadata passthrought support in platform ICE packer. I think only NVIDIA Shield has this support for now.