asciidisco / plugin.video.netflix

Inputstream based Netflix plugin for Kodi
MIT License
1.24k stars 226 forks source link

Conversion to MSL V2 API #682

Open nzsjb opened 5 years ago

nzsjb commented 5 years ago

I'm submitting a ...

General infomration

Is there any reason you didn't implement the V2 format for the cipher text envelope when the header has been converted?

There is nothing about the V2 format in MSLCrypto.py and the 'cipherspec' line is commented out and the version set to 1 in MSLMediaDrm.py.

Prerequisites

Description

[Description of the bug or feature]

Steps to Reproduce

  1. [First Step]
  2. [Second Step]
  3. [and so on...]

Expected behavior: [What you expected to happen]

Actual behavior: [What actually happened]

Context (Environment)

Installation

Operating System

Additional informatin on the environment

[Descripe your environment a bit more detailed, are you using LibreElec f.e.]

Debug log

[Please include a link to your debug log (use something like http://sprunge.us/) or similar, please do not paste]

Other information

[e.g. detailed explanation, related issues, suggestions how to fix, links for us to have context, etc.]

Screenshots

[Please add a screenshot if that helps understanding your problem]

[You can erase any parts of this template not applicable to your Issue.]

jakermx commented 5 years ago

Look at the MSLv2.py file... we did what the browser does when you navigate netflix and when you request a movie playback, there are some holes that we could fill, but, we just patch it and add some improvements on the fly.

I you have more info about MSL v2 it willl be great if you share it with us.

Thanks in advance.

jakermx commented 5 years ago

Yuo also might like to check v 0.14.0 on pull requests or nore updated one on @CastagnaIT fork.

nzsjb commented 5 years ago

Hi,

Thanks for your reply.

I think you probably know a lot more about this stuff than I do but if I find anything of interest I’ll let you know.

I tried the v2 format for the cipher text envelope and couldn’t get it to work so I was really asking the question to see if you had come across the same problem. I can’t remember what the issue was now but I’ll give it another try in the next few days.

My concern is that Netflix will retire the v1 interface at some point and our code will stop working. I’m kind of surprised they haven’t done it already.

Just so you know where I am coming from, I have built my own media player over the last decade that provides all the TV/radio/DVD/music features that I want and for the last couple of years I’ve focussed on streaming material. My code is all C# on Windows

I’ve had my own Netflix UI for quite some time while using a browser as a player but when I came across your plugin I decided to implement the player part as well. I had already developed all the parsing code for this type of data stream so it was the MSL and encryption side of things that I needed to add.

From: Jaker MX [mailto:notifications@github.com] Sent: Tuesday, 18 June 2019 4:44 p.m. To: asciidisco/plugin.video.netflix Cc: nzsjb; Author Subject: Re: [asciidisco/plugin.video.netflix] Conversion to MSL V2 API (#682)

Yuo also might like to check v 0.14.0 on pull requests or nore updated one on @CastagnaIT https://github.com/CastagnaIT fork.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/asciidisco/plugin.video.netflix/issues/682?email_source=notifications&email_token=ADIRYSLX2QBVU2JQ5VLHN4LP3BRZNA5CNFSM4HUNMUCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX5FGKQ#issuecomment-502944554 , or mute the thread https://github.com/notifications/unsubscribe-auth/ADIRYSL7L7U34GQFYUIFW3TP3BRZNANCNFSM4HUNMUCA .Image removed by sender.

jakermx commented 5 years ago

Hello,

I am not a programmer, my degree is on Networking , Electronics and Telecomms, but I do some code stuff for myself, and my daily work is as Trobleshooter Team Manager, so I like to solve things and I know enough of all to get my job done, so I helped to solve MSLv2 migration, but my coding skills are limited, but once I get it worked, the netflix addon team re did it more efficient, but if you want to learn more about it and have a small snippet you would like to try https://github.com/truedread/pymsl , actually all my findings on changes from v1 to v2 was ussing it... Also , if I have something you could need, just ask it... if I dont have it, I can figure out something...

Salud from Mexico!!

nzsjb commented 5 years ago

Hi again,

I have been programming for more years than I care to remember. I am impressed with what you managed to do if you say you have limited coding skills.

I have looked at the truedread code before and that helped in the early days.

Looking at the fork you pointed me to I can see that the Kodi addon team did a good job and the code has been refactored and tidied up quite a bit.

I’m no Python programmer but it’s pretty easy to read.

I’m working on the decryption side of things at the moment. It’s not always obvious how all the pieces fit together but I’m making progress. Thank you for your offer of assistance, it is much appreciated. Where would we be without open source?

Cheers from New Zealand.

From: Jaker MX [mailto:notifications@github.com] Sent: Thursday, 20 June 2019 12:04 p.m. To: asciidisco/plugin.video.netflix Cc: nzsjb; Author Subject: Re: [asciidisco/plugin.video.netflix] Conversion to MSL V2 API (#682)

Hello,

I am not a programmer, my degree is on Networking , Electronics and Telecomms, but I do some code stuff for myself, and my daily work is as Trobleshooter Team Manager, so I like to solve things and I know enough of all to get my job done, so I helped to solve MSLv2 migration, but my coding skills are limited, but once I get it worked, the netflix addon team re did it more efficient, but if you want to learn more about it and have a small snippet you would like to try https://github.com/truedread/pymsl , actually all my findings on changes from v1 to v2 was ussing it... Also , if I have something you could need, just ask it... if I dont have it, I can figure out something...

Salud from Mexico!!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/asciidisco/plugin.video.netflix/issues/682?email_source=notifications&email_token=ADIRYSJT3Z7JJRMMQSTZV53P3LCP7A5CNFSM4HUNMUCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYDTQLY#issuecomment-503789615 , or mute the thread https://github.com/notifications/unsubscribe-auth/ADIRYSJB36W46PPKBTBSUP3P3LCP7ANCNFSM4HUNMUCA .Image removed by sender.