search

asciidoc-py / asciidoc-py2

Deprecated python2 implementation of AsciiDoc.py. See asciidoc-py/asciidoc-py for current work.
https://asciidoc.org/
GNU General Public License v2.0
466 stars 128 forks source link

Convert over to python 3 #113

Closed moon-chilled closed 7 years ago

moon-chilled commented 7 years ago

It uses string instead of bytes now -- might slow it down, theoretically, but shrug.

elextr commented 7 years ago

Neat.

I don't think we should just replace the python2 version without LOTS of testing, so I created a repository python3 inside teh asciidoc organisation, if you could make this issue there it can then be converted and tested without removing the original.

moon-chilled commented 7 years ago

Alright, I'll move it over there. There are also some problems with the tests (beyond just moving to python3) that I have yet to sort out, so it's not done yet. I'm closing this for now since it's moving to the other repo. Also, might want rename the repository to something other than "python3," it makes it seem like you have your own fork of python. Maybe asciidoc-3?

elextr commented 7 years ago

Good point about the name, lemme see if I can find where github hides the menu for that, probably better you don't clone it until then.

elextr commented 7 years ago

Ok, asciidoc3, thanks for actually completing the job, this is the first complete conversion I have ever seen.

moon-chilled commented 7 years ago

Well...semi-complete. My only "test" was on the readme, which is pretty simple. There are still a bunch of other misc problems to kink out.

elextr commented 7 years ago

Thats why I wanted a different repo, I expect your first PR to be fairly major, we can discuss more there.