asciidocfx / AsciidocFX

Asciidoc Editor and Toolchain written with JavaFX 21 (Build PDF, Epub, Mobi and HTML books, documents and slides)
http://www.asciidocfx.com/
Apache License 2.0
1.91k stars 297 forks source link

Opening multiple tabs in AsciidoctorFX by opening files in filemanager #256

Open seriouslyEnter opened 8 years ago

seriouslyEnter commented 8 years ago

Request: After opening asciidocFX by opening an adoc file it is not possible to open another file the same way. It would be nice if it opens in another tab. Right now you have to open the next file in another tab through asciidoctorFX Also the Workdirectory should refresh when switching between tabs of different projects.

rahmanusta commented 8 years ago

Dear @seriouslyEnter , I couldn't understand the feature you proposed, could you please give me an example for it ?

seriouslyEnter commented 8 years ago

I looked into it again and it seems to be a bug.

Step by Step: 1) You open adoc file in filemanager. -> AsciidoctorFX starts and show the file 2) You try another adoc file in filemanager -> AsciidoctorFX does nothing. After step 2) DEBUG => Path x\xx not found in the filesystem DEBUG => Path xxx\xx\xx not found in the filesystem DEBUG => Path xxxx\xxx\xxxx\xxxx\x not found in the filesystem

alternatively: Also works when you start AsciidoctorFX and then try to open adoc file in filemanager. Opening adoc file through AsciidoctorFX works fine.

System: win10

rahmanusta commented 7 years ago

Hi @seriouslyEnter, I'm not facing this issue in Win 7, could you please record a short video to show the issue ?

Textureglitch commented 7 years ago

The bug seems to be triggered by a space in the file path, but it's only triggered when AsciidocFX is already open. In Windows File Explorer, I double-click an adoc file and it opens AsciidocFX with the file just fine. If I then double-click another adoc file (to open it in another tab), it fails.

The original file path is this: C:\Security\Security Design\security.adoc

This is the log output from AsciidocFX: DEBUG => Path C:\Security\Security not found in the filesystem DEBUG => Path C:\Program Files\AsciidocFX\Design\security.adoc not found in the filesystem

It has split the file path into two opening commands that both fail. The part of the file path after the space has been rerooted to the install location of AsciidocFX.

rahmanusta commented 7 years ago

@Textureglitch Thank you for clarifying the issue. It will be fixed.