asciidocfx / AsciidocFX

Asciidoc Editor and Toolchain written with JavaFX 21 (Build PDF, Epub, Mobi and HTML books, documents and slides)
http://www.asciidocfx.com/
Apache License 2.0
1.89k stars 297 forks source link

Diagrams in child documents do not render correctly in parent document (version 1.7.1) #435

Closed 3rady closed 3 years ago

3rady commented 5 years ago

Diagrams in child documents are not rendering properly. For example, create the following files:

File Parent.adoc:

include::Child1.adoc[]

include::Child2.adoc[]

File Child1.adoc:

.State Machine
[plantuml,States.png,png]
----
[*] --> State1
State1 --> State2
State2 --> State1
----

File Child2.adoc:


.Blocks
[ditaa,file="io.png"]
----
     +---+
     |   |
---->+   |
     |   |
     +---+
----

The child documents render fine on their own, but the parent document renders like this:

image

Environment:

lifei commented 4 years ago

same thing happen to me. any idea?

lifei commented 4 years ago

i check the old version 1.7.0, it works fine. so there must be something wrong between 1.7.0 and 1.7.1

lifei commented 4 years ago

https://github.com/asciidocfx/AsciidocFX/compare/v1.7.0...v1.7.1

lifei commented 4 years ago

when I changed the directory conf/public with the one of version 1.7.0, the problem is gone. so there must be some untested changes in these javascript files which lead to this issue.

rahmanusta commented 4 years ago

Hi, can you check the new release ? https://github.com/asciidocfx/AsciidocFX/releases/tag/v1.7.2

lifei commented 4 years ago

it works fine in v1.7.2