Open ghost opened 3 years ago
https://github.com/asciidocfx/AsciidocFX/blob/91679fe90bd2debe238ed1e0721e0e2aaf36fe72/src/main/java/com/kodedu/boot/AppStarter.java#L105
Consider using a walking the resources instead of hard-coding font names within the source code:
This also avoids a little repetition in the code. Note that the resource stream in AsciidocFX is not closed, which could be considered a bug (times seven because of the code duplication).
Hi, thank you, this is true that we have to close the open stream here. Any pull requests are welcome. ResourceWalker is nice, and I like it.
https://github.com/asciidocfx/AsciidocFX/blob/91679fe90bd2debe238ed1e0721e0e2aaf36fe72/src/main/java/com/kodedu/boot/AppStarter.java#L105
Consider using a walking the resources instead of hard-coding font names within the source code:
This also avoids a little repetition in the code. Note that the resource stream in AsciidocFX is not closed, which could be considered a bug (times seven because of the code duplication).