URGENT: asciidocfx does not create ditaa - diagrams when hash has not changed (means after you finished your code)

erdincay commented 3 years ago

open asciidocfx
create an asciidoc file
create an ditaa diagram
finish your ditaa diagram

[ditaa]
....
                   +-------------+
                   | Asciidoctor |-------+
                   |   diagram   |       |
                   +-------------+       | PNG out
                       ^                 |
                       | ditaa in        |
                       |                 v
+--------+   +--------+----+    +---------------+
|        +---+ Asciidoctor +--->|               |
|  Text  |   +-------------+    |   Beautiful   |
|Document|   |   !magic!   |    |    Output     |
|     {d}|   |             |    |               |
+---+----+   +-------------+    \---------------/
     :                                   ^
     |          Lotsxx of work           |
     +-----------------------------------+
....

close asciidocfx
restart asciidocfx
diagram is not generated

Turning off the Cache did not change this, I assume it does not create the diagram when the HASH does not change, OR I assume that the cached file is somewhat deleted ?

Environment:

Windows 10 - Version 1909
openjdk version "1.8.0_282"
OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_282-b08)
OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.282-b08, mixed mode)

erdincay commented 3 years ago

@rahmanusta plz, urgent

lefou commented 3 years ago

@erdincay Did you forgot to append the patch for this urgent issue? I'm sure, providing a pull request with a fix will speed up a bugfix release significantly.

erdincay commented 3 years ago

@erdincay Did you forgot to append the patch for this urgent issue? I'm sure, providing a pull request with a fix will speed up a bugfix release significantly.

@lefou, which patch do you want from me?

i did not write any patch for this, as I do not know where the issue is, I assume deactivating the caching will do the job, but it does not work

rahmanusta commented 3 years ago

@erdincay type a key or click HTML/PDF to regenerate diagrams.

erdincay commented 3 years ago

grafik

@rahmanusta I did press a key, I did try regenerating the PDF to enable a recreation of the diagram, but it does not work, I have attached an screenshot for you.

When I change something in the diagram code, it generates it. (I add and remove the 'x' letter at 'Lotsxx')
When I do not change anything, I get this empty boxes. (see for the second diagram)
When I create 100 diagrams, I cannot modify each diagram to change the HASH to trigger a regeneration of the diagram in preview and in export (PDF, HTML, etc.).

erdincay commented 3 years ago

@rahmanusta have updated my previous answer with the image (please page reload to view)

rahmanusta commented 3 years ago

Please share your document so we can review.

erdincay commented 3 years ago

@rahmanusta thx, for your fast response: RS.adoc.txt

Please rename from 'RS.adoc.txt' to 'RS.adoc', GitHub does not allow uploading *.adoc files over this comment section.

I am using the latest Asciidoc FX - Version 1.7.3:


   #                 #   #      #                #####  #   #
  # #    ####   ###          ####   ###    ###   #       # #
 #   #  ###    #     #   #  #   #  #   #  #      ####     #
 #####    ###  #     #   #  #   #  #   #  #      #       # #
 #   #  ####    ###  #   #   ####   ###    ###   #      #   #
 ============================================================
 :: Asciidoc FX ::     (v1.7.3)

While looking up the Version I found following Error in the logs (this could be unrelated or related, I am not sure):

java.lang.reflect.InvocationTargetException
    at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
    at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
    at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
    at java.base/java.lang.reflect.Constructor.newInstanceWithCaller(Constructor.java:500)
    at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:481)
    at net.sourceforge.plantuml.ditaa.PSystemDitaa.exportDiagramNow(PSystemDitaa.java:123)
    at net.sourceforge.plantuml.AbstractPSystem.exportDiagram(AbstractPSystem.java:135)
    at net.sourceforge.plantuml.SourceStringReader.outputImage(SourceStringReader.java:158)
    at net.sourceforge.plantuml.SourceStringReader.outputImage(SourceStringReader.java:130)
    at com.kodedu.service.extension.PlantUmlService.lambda$plantUml$1(PlantUmlService.java:123)
    at com.kodedu.service.ThreadService$1.call(ThreadService.java:48)
    at javafx.graphics/javafx.concurrent.Task$TaskCallable.call(Task.java:1425)
    at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
    at java.base/java.util.concurrent.ForkJoinTask$AdaptedRunnableAction.exec(ForkJoinTask.java:1406)
    at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
    at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1020)
    at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1656)
    at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1594)
    at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:177)
Caused by: java.lang.IndexOutOfBoundsException: Index 0 out of bounds for length 0
    at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
    at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
    at java.base/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:248)
    at java.base/java.util.Objects.checkIndex(Objects.java:372)
    at java.base/java.util.ArrayList.get(ArrayList.java:458)
    at org.stathissideris.ascii2image.text.GridPattern.isMatchedBy(GridPattern.java:113)
    at org.stathissideris.ascii2image.text.GridPatternGroup.isAnyMatchedBy(GridPatternGroup.java:44)
    at org.stathissideris.ascii2image.text.TextGrid.matchesAny(TextGrid.java:704)
    at org.stathissideris.ascii2image.text.TextGrid.matchesAny(TextGrid.java:1206)
    at org.stathissideris.ascii2image.text.TextGrid.isNormalCorner(TextGrid.java:1246)
    at org.stathissideris.ascii2image.text.TextGrid.isNormalCorner(TextGrid.java:1249)
    at org.stathissideris.ascii2image.text.TextGrid.isCorner(TextGrid.java:1200)
    at org.stathissideris.ascii2image.text.TextGrid.isCorner(TextGrid.java:1197)
    at org.stathissideris.ascii2image.text.TextGrid.isBoundary(TextGrid.java:744)
    at org.stathissideris.ascii2image.text.TextGrid.getAllBoundaries(TextGrid.java:459)
    at org.stathissideris.ascii2image.graphics.Diagram.<init>(Diagram.java:127)
    ... 19 more

rahmanusta commented 3 years ago

Seems there is a bug, I'll it take a look.

erdincay commented 3 years ago

Seems there is a bug, I'll it take a look.

Is there any update on this issue, @rahmanusta ?

rahmanusta commented 3 years ago

It will be fixed in the next release, it is in progress.

erdincay commented 3 years ago

It will be fixed in the next release, it is in progress.

hi @rahmanusta, do you have any date for the next release of AsciidocFX?

rahmanusta commented 3 years ago

@erdincay Working on this, most probably will be in May.

rahmanusta commented 3 years ago

New release is available https://github.com/asciidocfx/AsciidocFX/releases/tag/v1.7.4

rahmanusta commented 3 years ago

I’m closing the issue, let me know if you need help

erdincay commented 3 years ago

I’m closing the issue, let me know if you need help

Everything is working fine, will report back in case of any issues! Well done, and big thanks from our team.

asciidocfx / AsciidocFX

URGENT: asciidocfx does not create ditaa - diagrams when hash has not changed (means after you finished your code) #503