asciidocfx / AsciidocFX

Asciidoc Editor and Toolchain written with JavaFX 21 (Build PDF, Epub, Mobi and HTML books, documents and slides)
http://www.asciidocfx.com/
Apache License 2.0
1.88k stars 295 forks source link

Feature/create services interfaces #521

Closed Ayowel closed 3 years ago

Ayowel commented 3 years ago

See #519

The event service has an example use-case to notify of a working directory update across the application and lower coupling (in this case, it drops an explicit dependency to an UI component). I will be using it more as I find other use-cases in the code base, didn't look too much.

This PR also explicitly set components names. This might not seem like much now but it should be a first step toward allowing feature discovery later down the road.

As an aside : I tried to implement a ServiceLoader but was not happy with it as it did not make use of spring features and would just have made the application more bloated. Will give it another go when i find a more fitting design. For now, it feels like autowired components should be configured as attributes instead of being provided in constructor to limit the bloat seen in #272 .

rahmanusta commented 3 years ago

Hi, I merged changes to the development branch. We can merge development to master branch before we plan the release.

Thank you!