Closed gillesB closed 2 years ago
Hi @gillesB , thanks for the PR. It looks a very nice step to move on AsciidoctorJ. I checked the code out and PDF conversion with AsciidoctorJ has worked well. Keep going the awesome work!
@gillesB Reviewing the last commit, it looks perfect!
Hi @gillesB merged changes to asciidoctorj_backend branch, and additionally implemented the tree block processor
Hi @rahmanusta, thank you for the information. When I continue the work (I do not know when my family allows it) I will base the work on that branch.
According to https://github.com/asciidocfx/AsciidocFX/pull/345 the requirements for an Asciidocj integration are:
uml
must be replaced withplantuml
)plantuml
block)The checkboxes mark what is implemented in this PR. As this is my first contribution to this project I did not want to implement everything at once, but ask if I am on the right track before continuing.
As I wanted to reuse as much code as possible, I had to extend
AsciidoctorConfigBase
a bit. This change is needed becausePdfConfigBean
needs more properties thanAsciidoctorConfigBase
provides.