asciidocfx / AsciidocFX

Asciidoc Editor and Toolchain written with JavaFX 21 (Build PDF, Epub, Mobi and HTML books, documents and slides)
http://www.asciidocfx.com/
Apache License 2.0
1.9k stars 299 forks source link

Continuation of "Asciidocj integration" #548

Closed gillesB closed 2 years ago

gillesB commented 2 years ago

According to https://github.com/asciidocfx/AsciidocFX/pull/345 the requirements for an Asciidocj integration are:

The checkboxes mark what is implemented in this PR. As this is my first contribution to this project I did not want to implement everything at once, but ask if I am on the right track before continuing.

As I wanted to reuse as much code as possible, I had to extend AsciidoctorConfigBase a bit. This change is needed because PdfConfigBean needs more properties than AsciidoctorConfigBase provides.

rahmanusta commented 2 years ago

Hi @gillesB , thanks for the PR. It looks a very nice step to move on AsciidoctorJ. I checked the code out and PDF conversion with AsciidoctorJ has worked well. Keep going the awesome work!

rahmanusta commented 2 years ago

@gillesB Reviewing the last commit, it looks perfect!

rahmanusta commented 2 years ago

Hi @gillesB merged changes to asciidoctorj_backend branch, and additionally implemented the tree block processor

gillesB commented 2 years ago

Hi @rahmanusta, thank you for the information. When I continue the work (I do not know when my family allows it) I will base the work on that branch.