asciidocfx / AsciidocFX

Asciidoc Editor and Toolchain written with JavaFX 21 (Build PDF, Epub, Mobi and HTML books, documents and slides)
http://www.asciidocfx.com/
Apache License 2.0
1.9k stars 299 forks source link

Update to current plantuml.jar & support of "skin rose" to use former color scheme #552

Closed bohni closed 2 years ago

bohni commented 2 years ago

plantuml has new releases, current is v1.2022.06

Since 1.2022.01 there is a new color scheme.

Old behavior can be obtained by using "skin rose", but this is ignored in AsciidocFX 1.7.4 with new plantuml.jar copied to lib-folder

rahmanusta commented 2 years ago

Hi,

Can you give a try to https://github.com/asciidocfx/AsciidocFX/releases/tag/v1.7.5 ?

It has v1.2022.5

bohni commented 2 years ago

Sorry for answering just now.

I downloaded 1.7.5, but in /lib there is now plantuml-1.2021.16.jar

So there is still the old color scheme active.

rahmanusta commented 2 years ago

Hi, sorry, AsciidoctorJ has its own plantuml version and separate from the one under /lib. However, I'm not sure the old one will interfere with the version in AsciidoctorJ. More story short, I updated the v1.7.5 with version change https://github.com/asciidocfx/AsciidocFX/releases/tag/v1.7.5 , it now includes the v1.2022.5

bohni commented 2 years ago

Thanks, issue solved.

Rendering now uses new color scheme.

"skin rose" is now supported for old color scheme