(main) Remove maven-shade-plugin to publish original pom (#120)

asciidoctor / asciidoclet

:clipboard: A Javadoc Doclet based on Asciidoctor that lets you write Javadoc in the AsciiDoc syntax.

https://github.com/asciidoctor/asciidoclet

Apache License 2.0

132 stars 40 forks source link

(main) Remove maven-shade-plugin to publish original pom (#120) #132

Closed abelsromero closed 3 months ago

abelsromero commented 3 months ago

The shade-plugin alters the pom.xml removing runtime dependencies. This makes that components consuming asciidoclet cannot resolve required dependencies like AsciidoctorJ, causing conversion to fail.

closes #120

abelsromero commented 3 months ago

I don't know what caused the maven-shade-plugin to be added in the first place but I did some end-2-end tests (java 17) and without it, the project build fine, IT run, and can be consumed without having to embed dependencies (these are resolved and installed by Maven).