search

asciidoctor / asciidoclet

:clipboard: A Javadoc Doclet based on Asciidoctor that lets you write Javadoc in the AsciiDoc syntax.
https://github.com/asciidoctor/asciidoclet
Apache License 2.0
133 stars 40 forks source link

Upgraded to latest asciidoctorj #60

Closed johncarl81 closed 6 years ago

msgilligan commented 6 years ago

Is there an issue preventing this PR from being merged? Can/should we upgrade to asciidoctorj 1.5.6?

johncarl81 commented 6 years ago

Only that I don't like to merge my own PRs :wink:. I upgraded to 1.5.6 too.

msgilligan commented 6 years ago

I can help with that if you like :-)

msgilligan commented 6 years ago

So, can we get @mojavelinux to merge this one?

johncarl81 commented 6 years ago

If you want to merge it, go ahead @msgilligan

msgilligan commented 6 years ago

I don't have write access to this repo, but I'm hinting...

mojavelinux commented 6 years ago

I don't want to take over merges for this project as it wouldn't be my place. @msgilligan I vote to have you join the committers group. Would you accept?

msgilligan commented 6 years ago

I would happily accept. 👍

mojavelinux commented 6 years ago

Awesome! I'll add you then. Welcome aboard!

mojavelinux commented 6 years ago

Visit https://github.com/asciidoctor to accept.