search

asciidoctor / asciidoclet

:clipboard: A Javadoc Doclet based on Asciidoctor that lets you write Javadoc in the AsciiDoc syntax.
https://github.com/asciidoctor/asciidoclet
Apache License 2.0
133 stars 40 forks source link

Gradle 3.0 support #62

Closed msgilligan closed 7 years ago

msgilligan commented 7 years ago

I'm trying to upgrade my bitcoinj-addons repository to Gradle 3.1-rc-1 and when I try to run Gradle (even a gradle clean) I get the following error message:

Cannot change strategy of configuration ':asciidoclet' after it has been resolved.

This is true as of https://github.com/msgilligan/bitcoinj-addons/commit/e22470eb3b56c92dd7ff488f6a7ff91ea313bc14

Am I doing something wrong? Has anyone used asciidoclet with Gradle 3.x yet?

p.s. the "Composite Builds" feature of Gradle 3.1 is really awesome -- people with library projects are going to want to upgrade to it quickly, I think.

johncarl81 commented 7 years ago

@msgilligan, I'm not seeing this error message when I build from master. Is it happening on another branch perhaps?

msgilligan commented 7 years ago

Are you building from master with ./gradlew or with a locally installed Gradle 3.0 and the gradle command from your shell path?

The Gradle wrapper on master is still using Gradle 2.14.1, I was testing the build with a locally installed (via the sdk command) Gradle 3.1-rc-1.

msgilligan commented 7 years ago

And I should also mention that I get deprecation warnings under 2.14.1 indicating that the build will break under 3.0...

Changed strategy of configuration ':asciidoclet' after it has been resolved. This behaviour has been deprecated and is scheduled to be removed in Gradle 3.0
johncarl81 commented 7 years ago

Looks like I missed these updates.. im building using ./gradlew clean build, which uses version 2.14.1. Using the non-wrapper gradle from a manual install (https://gradle.org/gradle-download/) I get the following:

gradle clean build
Parallel execution is an incubating feature.
Using the 'clean' task in combination with parallel execution may lead to unexpected runtime behavior.

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'bitcoinj-addons'.
> Cannot change strategy of configuration ':asciidoclet' after it has been resolved.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

.. Digging into it further.

johncarl81 commented 7 years ago

@benevans, would you mind taking a look at this? I may be out of my depth with Gradle.

msgilligan commented 7 years ago

Any updates on this issue? It's keeping me from upgrading beyond Gradle 2.x and I might have to revert to standard JavaDoc from AsciiDoc in order to upgrade Gradle.

johncarl81 commented 7 years ago

My appologies @msgilligan, I have not focused on this issue. @benevans, any chance you could look at this? @mojavelinux?

johncarl81 commented 7 years ago

@msgilligan, I was able to build your project after upgrading gradle to version 3.1. Could you walk me through reproducing the error?

msgilligan commented 7 years ago

Yeah, seems to be working for me now, too. It fails if you check out the exact commit I referenced in the initial report. I'm guessing the upgrade to Groovy or another dependency upgrade I made had a side effect of fixing this issue.

I think we can go ahead and close it and reopen (or open a new one) if the problem raises its head again.

I just upgraded the master branch of bitcoinj-addons all the way to the latest Gradle, version 3.5.