Closed msgilligan closed 6 years ago
If you merge PR #74, this should pass the Travis CI PR check... @johncarl81 @mojavelinux
I recommend doing a squash & merge on this PR.
Note: I've tested these changes on two real-world projects: ConsensusJ and a closed-source project at work. (In both cases I tested with a -SNAPSHOT
version in mavenLocal()
.)
I trust you. I look forward to seeing how it looks!
Once you accept the contributor invitation, feel free to proceed with the merge.
I updated the Repository settings to protect the master
branch and to require:
before PRs can be merged. This can be overridden by administrators.
So generally, I'm hoping we can get at least 1 approval on all pull requests before merging. @johncarl81 has said he likes to do it this way, and I agree. So let's have Github remind/encourage us to do it that way.
Once you accept the contributor invitation, feel free to proceed with the merge.
I'd still like to get formal approval via the Github Review mechanism.
@mojavelinux and/or @johncarl81 can you review or approve this PR and then I'll merge it. I don't mind merging my own PR after an explicit review, but would prefer not to do it without the review(s). Thanks!
100% in support of your proposal to require code reviews.
Java 9 (and 10+) support
src/main/resources/stylesheet9.css
) for Java 9 (and 10+)Stylesheets.java
I have tested this briefly on a local build of ConsensusJ/consensusj
It would be a good idea for someone who knows and understands the stylesheets better to check my work. I created the new stylesheet with the following 3-way merge command: