search

asciidoctor / asciidoclet

:clipboard: A Javadoc Doclet based on Asciidoctor that lets you write Javadoc in the AsciiDoc syntax.
https://github.com/asciidoctor/asciidoclet
Apache License 2.0
133 stars 40 forks source link

Remove maven-assembly-plugin to unbundle dependencies #84

Closed msgilligan closed 6 years ago

msgilligan commented 6 years ago

Should resolve Issue #70.

johncarl81 commented 6 years ago

Like I mentioned, I think we should support both a regular and uber jar.

msgilligan commented 6 years ago

There was one guy in 2014 that requested (and liked) the uber jar. Is there anyone else that wants it? I vote for keeping things simple. It's pretty rare that projects go through the trouble of generating JavaDoc without using a build tool.

I wish there were a general-purpose pure-Java tool that would automatically generate a classpath from Maven/POM dependencies. (I Googled a little and didn't find anything.) In the Groovy world there are:

I really wish there was a straightforward Java-only solution to do this sort of things. I'm surprised there isn't.

reckart commented 6 years ago

@msgilligan If you have the Maven POM would the Maven Exec Plugin serve?

johncarl81 commented 6 years ago

@reckart I don't think so because this is used as a library, not an executable. @msgilligan what do you think of my proposed shade plugin snippet?

msgilligan commented 6 years ago

In general, I've found that life is simplest when a build module/submodule produces a single artifact. Whenever I make shade jars I often regret the extra complexity. You end up with two Jars that must be published/distributed/distinguished.

If the shade plugin works and you really want to continue to support this use case, let's close this PR and make a new one.

johncarl81 commented 6 years ago

Let me know what you think @msgilligan: https://github.com/asciidoctor/asciidoclet/pull/86

msgilligan commented 6 years ago

Closing in favor of #86 .