Closed msgilligan closed 6 years ago
I think there are still some issues with AsciidoctorJ 1.5.7 -- see the latest discussion on Issue #45 ...
I'm wondering if the problem we're having with AsciidoctorJ 1.5.7 / JRuby 9 is being caused by Guava or some other dependency. I cannot reproduce the problem anywhere else except Asciidoclet.
If worse comes to worse, we'll just have to roll out another release that includes the following change to Asciidoctor core. See https://github.com/asciidoctor/asciidoctor/commit/20c8c9bdc75dc8cb4a3e168c9c61751ed5182139
Aside from that problem, everything else seems to work great.
Taking a look :eyes:
@mojavelinux @johncarl81 What are the next steps?
I'll defer to @mojavelinux for the Asciidoctor issue here. For Asciidoclet, we could convert the haml over to slim I guess.
@msgilligan I think we need to wait on upgrading to 1.5.7 until https://github.com/asciidoctor/asciidoclet/issues/45 is resolved. In the mean time we can issue a release of 1.5.6. WDYT?
Sounds like a plan. Closing...
I'd like to submit a PR bumping Guava and slf4j and also making the version 1.5.6-SNAPSHOT, sound good?
Sounds great @msgilligan !