search

asciidoctor / asciidoclet

:clipboard: A Javadoc Doclet based on Asciidoctor that lets you write Javadoc in the AsciiDoc syntax.
https://github.com/asciidoctor/asciidoclet
Apache License 2.0
133 stars 40 forks source link

Update to AsciidoctorJ 1.5.7 #85

Closed msgilligan closed 6 years ago

msgilligan commented 6 years ago
msgilligan commented 6 years ago

I think there are still some issues with AsciidoctorJ 1.5.7 -- see the latest discussion on Issue #45 ...

mojavelinux commented 6 years ago

I'm wondering if the problem we're having with AsciidoctorJ 1.5.7 / JRuby 9 is being caused by Guava or some other dependency. I cannot reproduce the problem anywhere else except Asciidoclet.

If worse comes to worse, we'll just have to roll out another release that includes the following change to Asciidoctor core. See https://github.com/asciidoctor/asciidoctor/commit/20c8c9bdc75dc8cb4a3e168c9c61751ed5182139

Aside from that problem, everything else seems to work great.

johncarl81 commented 6 years ago

Taking a look :eyes:

msgilligan commented 6 years ago

@mojavelinux @johncarl81 What are the next steps?

johncarl81 commented 6 years ago

I'll defer to @mojavelinux for the Asciidoctor issue here. For Asciidoclet, we could convert the haml over to slim I guess.

johncarl81 commented 6 years ago

@msgilligan I think we need to wait on upgrading to 1.5.7 until https://github.com/asciidoctor/asciidoclet/issues/45 is resolved. In the mean time we can issue a release of 1.5.6. WDYT?

msgilligan commented 6 years ago

Sounds like a plan. Closing...

msgilligan commented 6 years ago

I'd like to submit a PR bumping Guava and slf4j and also making the version 1.5.6-SNAPSHOT, sound good?

johncarl81 commented 6 years ago

Sounds great @msgilligan !