search

asciidoctor / asciidoctor-ant

:ant: Ant task to render Asciidoc documentation
Apache License 2.0
9 stars 5 forks source link

Update TravisCi to Trusty: #67

Closed abelsromero closed 6 years ago

abelsromero commented 6 years ago

Summary: TravisCI launched a new Ubuntu distro for Linux build and settings need to be updated

PR includes:

Long story here: https://github.com/asciidoctor/asciidoctorj/issues/575

Here we discuss with @mojavelinux about dropping support for Java6 https://github.com/asciidoctor/asciidoctor-maven-plugin/pull/309 I am not sure if it is in the scope of the Ant plugin to also drop support for 6, but seems quite reasonable. Let's discuss it anyway :smile:

binout commented 6 years ago

Ok thanks for TravisCI update.

About dropping Java6 in ant plugin, it was planned in 1.6.X release https://github.com/asciidoctor/asciidoctor-ant/commit/1efe33163e555888ff085c56070f3b30b228b2d1

but i'm totally ok to move forward already in the next version 1.5.5, as the other asciidoctor projects

abelsromero commented 6 years ago

About dropping Java6 in ant plugin, it was planned in 1.6.X release

It was the plan for all Java projects (asciidoctorj, maven, ant, etc.) but third dependencies forced AsciidoctorJ to move to 7. It's almost 2018, I think it make sense for the other projects to move. In any case, feel free to keep this open more time just in case someone has something to say.

Btw, nice touch upgrading the pom, I will add that to the maven plugin.

mojavelinux commented 6 years ago

And as I mentioned in another thread, I think we should set a policy that is easy to follow. I think we should support the last 3 major versions of Java (7, 8, 9). That way, we don't have to keep revisiting the decision over and over.