search

asciidoctor / asciidoctor-backends

Backends (i.e., templates) for Asciidoctor, a Ruby port of AsciiDoc.
http://asciidoctor.org
Other
65 stars 73 forks source link

Include attribute to add third party javascript #112

Closed cmoulliard closed 9 years ago

cmoulliard commented 9 years ago

The slim backend (document.html.slim) manages stylesheet attribute to include "third party" theme

Example coming from the doc : http://asciidoctor.org/docs/user-manual/#applying-a-theme

:stylesheet: mystyles.css

We should provide such capability for javascript too

:script: myjavascript.js

Rendered into : 

<script type='text/javascript' src='myjavascript.js'></script>
mojavelinux commented 9 years ago

While I'm not opposed to this idea, I think it would be best implemented as a DocinfoProcessor extension. That way, it will work regardless of which HTML converter you are using.

I'm going to move the issue into the asciidoctor-extensions-lab repository. At the very least, I want to prototype a solution there.

The reason I'm not particularly comfortable having this in core is because I think it couples content to presentation too much. A stylesheet is already pushing it, but I think scripts goes too far. Of course, you are going to need such a feature from time to time, which is exactly why we are beefing up the extension model.

The slim backend (document.html.slim) manages stylesheet attribute to include "third party" theme

This is true of all the HTML converters. It's always been a core feature of AsciiDoc Python, so we implemented it in Asciidoctor as well.

mojavelinux commented 9 years ago

See https://github.com/asciidoctor/asciidoctor-extensions-lab/issues/31.

cmoulliard commented 9 years ago

Thx to answer to the ticket Dan. In the meantime, I have implemented this feature in hyla project : https://github.com/cmoulliard/hyla/commit/f0754c6f5bc091cef01da7df045c2dae6a609d23

On Sat, Dec 20, 2014 at 9:03 AM, Dan Allen notifications@github.com wrote:

See asciidoctor/asciidoctor-extensions-lab#31 https://github.com/asciidoctor/asciidoctor-extensions-lab/issues/31.

— Reply to this email directly or view it on GitHub https://github.com/asciidoctor/asciidoctor-backends/issues/112#issuecomment-67728643 .

Charles Moulliard Apache Committer / Architect @RedHat Twitter : @cmoulliard | Blog : http://cmoulliard.github.io