On Firefox: diagrams feature enabled - fails

[mbeckerle]

Version 2.3.0

Firefox version 70.0.1 (64-bit)

If I install as a firefox add-on/extension, then I enable the diagrams feature by checking the box in the preferences/settings for this extension. Then when I try to view an asciidoc page that has a diagram, I get "Error

ReferenceError : AsciidoctorKroki is not defined"

This same thing viewing the same file, works fine on Chrome.

[ggrossetie]

Hi @mbeckerle

I can reproduce this issue. There were some specific issues with Firefox. It should be fixed in https://github.com/asciidoctor/asciidoctor-browser-extension/pull/311

Could you please consider editing your review on the Firefox Add-ons ? I don't think the extension deserves a 1/5 stars because a feature is not working at a given time on a specific browser: https://addons.mozilla.org/fr/firefox/addon/asciidoctorjs-live-preview/reviews/?score=1

Thanks

[mbeckerle]

Deleted the bad review. When I can reinstall this plug in and it works again I will post 5 stars.

This is fantastically responsive. Much appreciated.

-mike

---

From: Guillaume Grossetie notifications@github.com Sent: Wednesday, November 6, 2019 4:08 AM To: asciidoctor/asciidoctor-browser-extension asciidoctor-browser-extension@noreply.github.com Cc: Beckerle, Mike mbeckerle@tresys.com; Mention mention@noreply.github.com Subject: Re: [asciidoctor/asciidoctor-browser-extension] On Firefox: diagrams feature enabled - fails (#310)

Hi @mbeckerlehttps://github.com/mbeckerle

I can reproduce this issue. There were some specific issues with Firefox. It should be fixed in #311https://github.com/asciidoctor/asciidoctor-browser-extension/pull/311

Could you please consider editing your review on the Firefox Add-ons ? I don't think the extension deserves a 1/5 stars because a feature is not working at a given time on a specific browser: https://addons.mozilla.org/fr/firefox/addon/asciidoctorjs-live-preview/reviews/?score=1

Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/asciidoctor/asciidoctor-browser-extension/issues/310?email_source=notifications&email_token=AALUDAYS6JHB47Y6IQUHRWDQSKCRRA5CNFSM4JJOMPL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDF2A5I#issuecomment-550215797, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AALUDA7HBONCQTRLLNGY7HLQSKCRRANCNFSM4JJOMPLQ.

[ggrossetie]

Thanks for reconsidering your review :+1:

I'm making sure it's working on Chrome and Opera as well. Hopefully I will release a new version at the end of this week.

[ggrossetie]

I've published a new version 2.3.1. Once it's approved by the Firefox team it will be available on https://addons.mozilla.org/

If you don't want to wait, you can install the xpi:

• Download the xpi file from the release page: https://github.com/asciidoctor/asciidoctor-browser-extension/releases/tag/v2.3.1
• Open about:addons
• Click Install Add-on From File

• Select the xpi file
• Enable Kroki from the extension options
• Enjoy!

Please note that for security reasons the following syntax does not work on Firefox:

plantuml::components.puml[]

See: https://github.com/asciidoctor/asciidoctor-browser-extension/issues/302

[ggrossetie]

Version 2.3.1 is now available on the Firefox Add-ons website: https://addons.mozilla.org/firefox/addon/asciidoctorjs-live-preview/

@mbeckerle Could you please confirm that this issue is fixed?

[mbeckerle]

Alas does not work for me. I installed, checked the box in preferences for allowing diagrams. Then view a file URL of an asciidoc file I have with diagrams in it. I get:

Error ReferenceError : AsciidoctorKroki is not defined

[ggrossetie]

Are you sure that you are using the latest version? Could you please go to about:addons and check the version:

You might need to click "Check for Updates" and "Install update".

[mbeckerle]

It says version 2.3.1.

[mbeckerle]

Ah, a restart of Firefox, and now it is working.

[ggrossetie]

Great :ok_hand: